Move compose variables into brick config file #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dido18
suggested changes
Dec 5, 2025
src/arduino/app_bricks/video_imageclassification/brick_config.yaml
Outdated
Show resolved
Hide resolved
dido18
reviewed
Dec 10, 2025
dido18
left a comment
dido18
left a comment
There was a problem hiding this comment.
Since the added hidden variables do not have a default_value, they are all required variables.
By design, the validation of the app fails if required variables are not set.
I see two solutions:
- add the
default_valuefor the hidden variables
-2.edit the check on the app validation that if a variable is hidden the check of the required value is omitted. I.e., an hidden variable must not be enforced to have a value.
Contributor
Author
I've added the default values: 9c54121 |
stefanotorneo
requested changes
Dec 11, 2025
Contributor
stefanotorneo
left a comment
stefanotorneo
left a comment
There was a problem hiding this comment.
We removed the BIND_PORT from the other compose file; do we want to remove it from these bricks as well?
mirkokurt
force-pushed
the
hidden-brick-variables
branch
from
a797a34 to
bcfe0e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.