Auto-generate Cognito domain name #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the requirement for users to manually-configure Cognito domain in 2nd+ deployment, by automatically generating a globally-unique but repeatable domain name prefix in CDK: Inspired by CDK's own internal unique name generation utilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #9
Description of changes:
Remove the requirement for users to manually-configure Cognito domain in 2nd+ deployment, by automatically generating a globally-unique but repeatable domain name prefix in CDK.
As noted in the code comments, this approach is inspired by the globally-unique name generation tools that CDK itself uses for automatically naming resources that raw CloudFormation needs to be explicit.
Originally authored a few months ago and has seemed to work well for us - sorry it took so long to upstream! 😭
What it means for existing users:
I think users with existing deployments can (and should) leave their
cognito_domainset as-is in their config.json - since the new auto-generated value will not match what got created before. However, new deployments should be able to start with the field blank and leave it blank for stack updates.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.