Skip to content

Updae dockerfiles and badges #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guessi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updae dockerfiles and badges #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.25 as builder
FROM public.ecr.aws/docker/library/golang:1.25 as builder

## GOLANG env
ARG GOPROXY="https://proxy.golang.org|direct"
Expand All @@ -22,7 +22,8 @@ RUN make build
CMD ["/amazon-ec2-instance-selector/build/ec2-instance-selector"]

# Copy the binary into a thin image
FROM amazonlinux:2 as amazonlinux
FROM public.ecr.aws/amazonlinux/amazonlinux:2023-minimal as amazonlinux

FROM scratch
WORKDIR /
COPY --from=builder /amazon-ec2-instance-selector/build/ec2-instance-selector .
Expand Down
17 changes: 5 additions & 12 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,19 @@

<h4>A CLI tool and go library which recommends instance types based on resource criteria like vcpus and memory.</h4>

![GitHub go.mod Go version](https://img.shields.io/github/go-mod/go-version/aws/amazon-ec2-instance-selector)
[![GitHub License](https://img.shields.io/github/license/aws/amazon-ec2-instance-selector)](https://opensource.org/licenses/Apache-2.0)
[![Docker Pulls](https://img.shields.io/docker/pulls/amazon/amazon-ec2-instance-selector)](https://hub.docker.com/r/amazon/amazon-ec2-instance-selector)

<p>
<a href="https://golang.org/doc/go1.23">
<img src="https://img.shields.io/github/go-mod/go-version/aws/amazon-ec2-instance-selector?color=blueviolet" alt="go-version">
</a>
<a href="https://opensource.org/licenses/Apache-2.0">
<img src="https://img.shields.io/badge/License-Apache%202.0-ff69b4.svg" alt="license">
</a>
<a href="https://goreportcard.com/report/github.com/aws/amazon-ec2-instance-selector">
<img src="https://goreportcard.com/badge/github.com/aws/amazon-ec2-instance-selector" alt="go-report-card">
</a>
<a href="https://hub.docker.com/r/amazon/amazon-ec2-instance-selector">
<img src="https://img.shields.io/docker/pulls/amazon/amazon-ec2-instance-selector" alt="docker-pulls">
</a>
</p>

![EC2 Instance Selector CI and Release](https://github.com/aws/amazon-ec2-instance-selector/workflows/EC2%20Instance%20Selector%20CI%20and%20Release/badge.svg)

<div>
<hr>
</div>
---

## Summary

Expand Down
2 changes: 1 addition & 1 deletion test/license-test/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM public.ecr.aws/docker/library/golang:1.23
FROM public.ecr.aws/docker/library/golang:1.25

WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion test/readme-test/rundoc-Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3
FROM public.ecr.aws/docker/library/python:3


RUN pip3 install rundoc
Expand Down
4 changes: 2 additions & 2 deletions test/readme-test/spellcheck-Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM golang:1.23
FROM public.ecr.aws/docker/library/golang:1.25

RUN go install github.com/client9/misspell/cmd/misspell@v0.3.4

CMD [ "/go/bin/misspell" ]
CMD [ "/go/bin/misspell" ]
Loading