Migrate recent commits in master-v2 #5423
Conversation
- Used latest code in commit: aws@9f70fb2#diff-6643c001ac6e4e110393f1a33700adf2054cc594e5ff1e3e2630131d2c6c0551
Code change is based on commit: aws@903cb8a
For commit: aws/sagemaker-python-sdk-staging@99210b2 Tested by running sagemaker-serve unit tests
…n if it presents in the resource metadata file For commit: aws/sagemaker-python-sdk-staging@b9df334
For commit: aws@5d3f175
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
aviruthen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
aviruthen
left a comment
aviruthen
left a comment
There was a problem hiding this comment.
Approved pending unit/integ tests passing
| NextToken=next_token, | ||
| MaxResults=max_results, | ||
| ) | ||
| return self.sagemaker_session.sagemaker_client.list_pipeline_versions(**kwargs) |
There was a problem hiding this comment.
Todo: we should move this to sagemaker core? can you note this down
There was a problem hiding this comment.
Added # TODO: replace with sagemaker-core methods before this line
| @@ -1,1030 +0,0 @@ | |||
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Can you confirm nothing is being missed from this file to the duplicate file?
There was a problem hiding this comment.
Yes this is a duplicate file and ModelTrainer in this file is not referenced anywhere. All the tests and recent commits are running against ModelTrainer in the other file
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
|
About massice image uri changes in this file, are units sufficiently covering any testing gaps? Can you confirm. |
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
I added 100+ V2 unit tests on image_uri_config so coverage should be good now. The changes were created by replacing image_uri with image_uri_config.json in master-v2 though
image_uri_config_updated is an unused folder I believe created during development. Every json there is already in image_uri_config |
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
4 participants
Issue #, if available:
Bring selected recent commits in master-v2 branch to master
Description of changes:
See commit message for change details
Tested by running updated unit tests. Only AI registry unit tests are failing in sagemaker-train (which is known):
sagemaker-serve has 2 failures which seemed flaky recently. Verified and they could pass locally:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.