test(whl_library): test a recent fix for pipstar

[aignas]

Test for fix for #3352 implemented in #3468.

[gemini-code-assist]

Summary of Changes

Hello @aignas, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test case to validate the correct resolution of optional dependencies (extras) within whl_library rules, particularly in the context of pipstar. It verifies a previous fix by ensuring that packages specifying [extra] requirements correctly pull in their associated optional dependencies, thereby confirming the robustness of the dependency resolution mechanism. The changes include adding new test data, a helper function for whl_library creation, and the test itself.

Highlights

• New Test Case for whl_library Extras: Introduced a new py_test named whl_library_extras_test to specifically verify the correct resolution of optional dependencies (extras) within whl_library rules, addressing a previous fix related to pipstar.
• Helper Function for whl_library from Directory: Added a new internal helper function _whl_library_from_dir in internal_dev_deps.bzl to streamline the creation of whl_library rules from local test data directories.
• Test Data for Optional Dependencies: Created new test packages, pkg and optional_dep, where pkg declares optional_dep as an extra dependency, allowing for a realistic test scenario for pipstar's extra resolution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces new test infrastructure and a test case for whl_library to verify the correct propagation of extras when pipstar is enabled. The new _whl_library_from_dir helper function effectively encapsulates the creation of test wheel repositories and libraries, improving the readability and maintainability of the test setup. The test case correctly asserts that optional dependencies are propagated as expected. The changes are well-implemented and directly address the stated objective of testing the fix for issue #3352.

[aignas]

This was not letting me extract without python.

[aignas]

I have no idea why it is failing... :/