-
Notifications
You must be signed in to change notification settings - Fork 71
chore(release): bump version to 0.24.0 and update CHANGELOG.md
#174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): bump version to 0.24.0 and update CHANGELOG.md
#174
Conversation
c2c0779 to
8f658cc
Compare
ValuedMammal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8f658cc
ValuedMammal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that ElectrumApi is a public trait, so should this be a bump to 0.24.0?
|
I'm fine with 0.23.2 or 0.24.0, the semantic versioning spec doesn't set any rules about how to bump the version for pre-1.0 releases; https://semver.org/#spec-item-4. |
Oh, you're right! It's considered a minor change, as per https://doc.rust-lang.org/cargo/reference/semver.html#item-new. I think it's best to use |
8f658cc to
24d07e2
Compare
0.23.2 and update CHANGELOG.md0.24.0 and update CHANGELOG.md
|
ACK 24d07e2 |
…rsion to `0.24.0` and update `CHANGELOG.md` 24d07e2cac0045be2c52bf4982cf8abc0def1cfc chore(release): update `CHANGELOG.md` (Leonardo Lima) fbffdfe65e846cbd9f42ab7df0854da2f35ec9bf chore(release): bump version to `0.24.0` (Leonardo Lima) Pull request description: fixes #173 - bump the crate version to `0.24.0`. - updates the `CHANGELOG.md` with relevant changes: bitcoindevkit/rust-electrum-client@0.24.0...HEAD ACKs for top commit: ValuedMammal: ACK 24d07e2cac0045be2c52bf4982cf8abc0def1cfc Tree-SHA512: 23060238562788fbc8d4ecdb2273db25329c4f645700d4d515a8d21a98b04bb421d0c8532d1b38ff566257d4df9095299d5b539261b88d090507350f80141d86
fixes #173
0.24.0.CHANGELOG.mdwith relevant changes: 0.24.0...HEAD