Skip to content

Conversation

@oleonardolima
Copy link
Contributor

@oleonardolima oleonardolima commented Jul 29, 2025

fixes #173

  • bump the crate version to 0.24.0.
  • updates the CHANGELOG.md with relevant changes: 0.24.0...HEAD

@oleonardolima oleonardolima self-assigned this Jul 29, 2025
@oleonardolima oleonardolima force-pushed the release/bump-version-to-0.23.2 branch from c2c0779 to 8f658cc Compare July 29, 2025 23:38
@oleonardolima oleonardolima marked this pull request as ready for review July 29, 2025 23:38
@oleonardolima oleonardolima moved this to Needs Review in BDK Wallet Jul 29, 2025
@oleonardolima oleonardolima moved this to Needs Review in BDK Chain Jul 29, 2025
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8f658cc

Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that ElectrumApi is a public trait, so should this be a bump to 0.24.0?

@notmandatory
Copy link
Member

I'm fine with 0.23.2 or 0.24.0, the semantic versioning spec doesn't set any rules about how to bump the version for pre-1.0 releases; https://semver.org/#spec-item-4.

@oleonardolima
Copy link
Contributor Author

I realized that ElectrumApi is a public trait, so should this be a bump to 0.24.0?

Oh, you're right! It's considered a minor change, as per https://doc.rust-lang.org/cargo/reference/semver.html#item-new. I think it's best to use 0.24.0 then.

@oleonardolima oleonardolima force-pushed the release/bump-version-to-0.23.2 branch from 8f658cc to 24d07e2 Compare July 30, 2025 14:44
@oleonardolima oleonardolima changed the title chore(release): bump version to 0.23.2 and update CHANGELOG.md chore(release): bump version to 0.24.0 and update CHANGELOG.md Jul 30, 2025
@ValuedMammal
Copy link
Contributor

ACK 24d07e2

@ValuedMammal ValuedMammal merged commit b20d41a into bitcoindevkit:master Jul 30, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Chain Jul 30, 2025
radiant-smith-lk20 added a commit to radiant-smith-lk20/rust-electrum-client that referenced this pull request Dec 15, 2025
…rsion to `0.24.0` and update `CHANGELOG.md`

24d07e2cac0045be2c52bf4982cf8abc0def1cfc chore(release): update `CHANGELOG.md` (Leonardo Lima)
fbffdfe65e846cbd9f42ab7df0854da2f35ec9bf chore(release): bump version to `0.24.0` (Leonardo Lima)

Pull request description:

  fixes #173

  - bump the crate version to `0.24.0`.
  - updates the `CHANGELOG.md` with relevant changes: bitcoindevkit/rust-electrum-client@0.24.0...HEAD

ACKs for top commit:
  ValuedMammal:
    ACK 24d07e2cac0045be2c52bf4982cf8abc0def1cfc

Tree-SHA512: 23060238562788fbc8d4ecdb2273db25329c4f645700d4d515a8d21a98b04bb421d0c8532d1b38ff566257d4df9095299d5b539261b88d090507350f80141d86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

release: electrum-client 0.24.0

3 participants