Skip to content

fix: use current selenium api #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TurekBot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use current selenium api #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PageObjectLibrary/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class your keywords have access to the following pre-defined
standard Selenium methods provided by the Selenium library. The
following example shows how to find all link elements on a page:

| elements = self.browser,find_elements_by_tag_name("a")
| elements = self.browser.find_elements(By.TAG_NAME, "a")

= Creating Page Object Classes =

Expand Down
3 changes: 2 additions & 1 deletion PageObjectLibrary/pageobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

from selenium.webdriver.support.expected_conditions import staleness_of
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.common.by import By

import six

Expand Down Expand Up @@ -91,7 +92,7 @@ def _wait_for_page_refresh(self, timeout=10):
2) the javascript document.readyState variable to be set
to "complete"
"""
old_page = self.browser.find_element_by_tag_name('html')
old_page = self.browser.find_element(By.TAG_NAME, 'html')
yield
WebDriverWait(self.browser, timeout).until(
staleness_of(old_page),
Expand Down
Loading