-
Notifications
You must be signed in to change notification settings - Fork 34
Add a calendar name to the ICS feed. #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add a calendar name to the ICS, to give Giggity and other clients a conference name. Inspired from https://www.paris-web.fr/2025/conferences-paris-web-2025.ics We could also add a `X-WR-CALDESC`description, but the `X-WR-CALNAME` seems to be the most important one.
It turns out that [RFC7986](https://www.rfc-editor.org/rfc/rfc7986#section-5.1) has standardized on ǸAME`.
|
Thanks, Bo! Would it make sense to include the year in the name? |
| cal = icalendar.Calendar() | ||
| cal.add("prodid", "-//BornHack Website iCal Generator//bornhack.dk//") | ||
| cal.add("version", "2.0") | ||
| cal.add("NAME", "BornHack") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| cal.add("NAME", "BornHack") | |
| cal.add("NAME", self.camp.title) |
| cal.add("prodid", "-//BornHack Website iCal Generator//bornhack.dk//") | ||
| cal.add("version", "2.0") | ||
| cal.add("NAME", "BornHack") | ||
| cal.add("X-WR-CALNAME", "BornHack") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| cal.add("X-WR-CALNAME", "BornHack") | |
| cal.add("X-WR-CALNAME", self.camp.title) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Bo! Would it make sense to include the year in the name?
I think not, but other conferences are doing it. Maybe we can try without the year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking if you have the bornhack ical thing added from 2025, and you then add the new one from 2026, having the same name for both of them would make it difficult to tell them apart (since we have different ical URLs per year)
Add a calendar name to the ICS, to give Giggity and other clients a conference name. Inspired from https://www.paris-web.fr/2025/conferences-paris-web-2025.ics We could also add a
X-WR-CALDESCdescription, but theX-WR-CALNAMEseems to be the most important one.Update:
NAMEhas been chosen as the standard key, in RFC7986. Lets keep both, for backwards compatibility.