Updated orca_wasm into wirm latest version #300
Conversation
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Thank you for splitting this off! I left a bunch of comments, addressing which I think should make this a very small diff indeed. I might be wrong about some assumptions though, as I didn't attempt any of these changes myself.
| } | ||
| } | ||
| builder.inject_at( | ||
| // Inject adjustments after the located instruction: add delta and add arg index |
There was a problem hiding this comment.
Why doesn't the inject_at approach work here anymore? Maybe you just couldn't find it anymore because it moved into the InjectAt trait? If you change the use wirm::opcode::Inject; statement to use wirm::opcode::{Inject, InjectAt}; I think the original code should work as before.
There was a problem hiding this comment.
Yeah I totally missed the InjectAt, added it back but the other code is necessary to set the instruction as it can't be done in the loop for the reason in the previous comment
vados-cosmonic
force-pushed
the
engodev/update-wirm
branch
from
95aedf1 to
70514fd
Compare
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Thank you for this, and apologies for the long delay in this last review!
3 participants
Split from #298