-
-
Notifications
You must be signed in to change notification settings - Fork 94
feat: add support for ClickHouse's query parameters in python binding #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Hi @niyue, thank you so much for your PR. Currently, there are two categories of test failures: |
…n issue parameterized queries without string interpolation.
3c6e4d5 to
3aaa73f
Compare
|
Thanks for the detailed information. I’ve updated the tests, but I don’t have a musl Linux environment to verify locally, so I’ll have to rely on the CI to validate the changes. Hopefully this fixes the CI issues. |
|
@wudidapaopao This PR is ready for review. Please let me know if there’s anything else I should revise. Thanks! |
Description
This PR adds support for ClickHouse query parameters and addresses #436.
It enables users to execute parameterized queries without manual string interpolation, resulting in more reusable query templates and reducing the risk of SQL injection.
Changelog category
Changelog entry
Add support for ClickHouse query parameters, allowing generic queries with typed placeholders.
Documentation entry for user-facing changes
Query parametersis a native ClickHouse feature, and the official documentation already covers their usage in detail, for example:This PR enables
chdbusers to take advantage of this feature directly.A brief introduction and examples have been added to both
README.mdandREADME-zh.md.Test
Several Python unit tests have been added to validate this functionality.