-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[ZT] WARP external emergency disconnect #26943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: production
Are you sure you want to change the base?
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
...t/docs/cloudflare-one/team-and-resources/devices/warp/configure-warp/warp-settings/index.mdx
Outdated
Show resolved
Hide resolved
…p/configure-warp/warp-settings/index.mdx
...are-one/team-and-resources/devices/warp/configure-warp/warp-settings/external-disconnect.mdx
Outdated
Show resolved
Hide resolved
merge in latest changes
|
|
||
| ### Dashboard or API | ||
|
|
||
| The External Emergency Disconnect state cannot be cleared from the Cloudflare One dashboard. To remove the feature configuration, send a `PATCH` request with the endpoint URL and fingerprint set to empty strings: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be cleared from the dashboard as long as CF infrastructure is up. The dashboard is just making this patch call behinds the scenes. Just toggling it to disabled should disable the feature in normal circumstances
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, simply turning off the dash setting does not clear the URL and fingerprint configuration. It seems to make a PATCH call but only changes "external_emergency_signal_enabled" --> false.
To clear the cached state, is it necessary to also clear the URL and fingerprint settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends what you mean by cached state. Right now if you are in a disconnected state via this external emergency disconnect if you disable the feature on the dash you will be able to connect relatively quickly (few minutes). The API underneath removes the external disconnect fields in the payload it sends to client so the client no longer exercises the feature.
We keep the fields beyond external_emergency_signal_enabled in the database as to allow the administrator to easily re-enable the feature without having to re-enter the settings they previously had to discover
| warp-cli registration delete | ||
| ``` | ||
|
|
||
| This command will clear the client registration, clear the local policy, and discard the cached emergency state. Users will need to [re-enroll WARP](/cloudflare-one/team-and-resources/devices/warp/deployment/manual-deployment/) with your Zero Trust organization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should make it clear the feature still needs to disabled on the dash before this would work for an individual user
|
Overall LGTM @kokolocomotion1 any thougts |
PCX-19846