Skip to content

Conversation

@Echin-h
Copy link
Contributor

@Echin-h Echin-h commented Dec 10, 2025

When I enter a FilePath that does not meet the specified rules, resp will be a null pointer error.

Copilot AI review requested due to automatic review settings December 10, 2025 07:24
@CLAassistant
Copy link

CLAassistant commented Dec 10, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a null pointer exception in the GetFileStructure function that occurred when an invalid file path was provided.

Key Changes

  • Modified error handling in GetFileStructure to return a new GetFileStructResp object instead of trying to set the Error field on a nil resp pointer

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Echin-h
Copy link
Contributor Author

Echin-h commented Dec 10, 2025

Fixes #129

Copy link
Collaborator

@Hoblovski Hoblovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Hoblovski
Copy link
Collaborator

Looks great. Would you sign the CLA so we can merge the PR?

@Echin-h
Copy link
Contributor Author

Echin-h commented Dec 10, 2025

Thank you for your affirmation, I have already signed the cla now.

@AsterDY AsterDY merged commit e3d823d into cloudwego:main Dec 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants