Skip to content

Conversation

@thisisharsh7
Copy link
Contributor

Changes

Made openai::Client generic over config type to eliminate duplication with azureopenai.rs

Results

  • Eliminates duplicated logic for embeddings, generation & json schema handling
  • follows same pattern as litellm.rs and openrouter.rs

Fixes #1364

@georgeh0
Copy link
Member

georgeh0 commented Dec 9, 2025

Please also fix the format check problem. You may want to install the pre-commit hook (https://cocoindex.io/docs/contributing/setup_dev_environment), and it'll automatically do a reformat.

@thisisharsh7
Copy link
Contributor Author

got it will do thanks!

  formatting
@thisisharsh7 thisisharsh7 marked this pull request as ready for review December 9, 2025 07:54
@georgeh0 georgeh0 merged commit e3f47fd into cocoindex-io:main Dec 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Make openai.rs more generic and fit into AzureConfig too

2 participants