Skip to content

Commit 0a3a286

Browse files
jgauffinjgauffin
committed
Minor fixes
1 parent 9899ec3 commit 0a3a286

File tree

12 files changed

+110
-93
lines changed

12 files changed

+110
-93
lines changed

‎src/Server/Coderr.Server.ReportAnalyzer/Inbound/SaveReportHandler.cs‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -198,22 +198,21 @@ private async Task StoreInvalidReportAsync(string appKey, string sig, string rem
198198
}
199199
}
200200

201-
private Task StoreReportAsync(ClaimsPrincipal user, ProcessReport report)
201+
private async Task StoreReportAsync(ClaimsPrincipal user, ProcessReport report)
202202
{
203203
try
204204
{
205205
using (var session = _queue.BeginSession())
206206
{
207-
session.EnqueueAsync(user, new Message(report));
208-
session.SaveChanges();
207+
await session.EnqueueAsync(user, new Message(report));
208+
await session.SaveChanges();
209209
}
210210
}
211211
catch (Exception ex)
212212
{
213213
_logger.Error(
214214
"Failed to StoreReport: " + JsonConvert.SerializeObject(new {model = report}), ex);
215215
}
216-
return Task.FromResult<object>(null);
217216
}
218217

219218
private class AppInfo

‎src/Server/Coderr.Server.Web/ClientApp/boot.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -143,14 +143,14 @@ const routes = [
143143
name: "analyzeFeedback",
144144
path: "incident/:incidentId/feedback/",
145145
component: require("./components/analyze/incidents/feedback.vue.html")
146-
},
147-
{
148-
name: "analyzeNotifyUsers",
149-
path: "incident/:incidentId/notify/",
150-
component: require("./components/analyze/incidents/status.vue.html")
151146
}
152147
]
153148
},
149+
{
150+
name: "notifyUsers",
151+
path: "users/notify/incident/:incidentId/",
152+
component: require("./components/analyze/incidents/status.vue.html")
153+
},
154154
{
155155
path: "/onboarding/",
156156
component: require("./components/onboarding/onboarding.vue.html"),

‎src/Server/Coderr.Server.Web/ClientApp/components/analyze/incidents/incident.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export default class AnalyzeIncidentComponent extends Vue {
6060
.then(x => {
6161
if (x.requiresStatusUpdate) {
6262
this.$router.push({
63-
name: 'analyzeNotifyUsers',
63+
name: 'notifyUsers',
6464
params: { incidentId: this.incident.Id.toString() }
6565
});
6666
return;

‎src/Server/Coderr.Server.Web/ClientApp/components/analyze/incidents/incident.vue.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<div class="float-right">
77
<div class="dropdown">
88
<button type="button" class="btn btn-outline-primary dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
9-
What do you want to do?
9+
Actions
1010
</button>
1111
<div class="dropdown-menu">
1212
<span class="dropdown-item" v-on:click="reAssign"><i class="fa-redo fa text-muted"></i> Re-assign</span>

‎src/Server/Coderr.Server.Web/ClientApp/components/analyze/incidents/report.vue.html‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ <h2>
2222
</div>
2323
<div class="row">
2424

25-
<div class="col-lg-5 col-xl-6 col-md-12 contextCollections">
25+
<div class="col-lg-12 col-xl-8 contextCollections">
2626
<div class="card">
2727
<div class="card-body">
2828
<h3>Context collections</h3>
@@ -49,16 +49,16 @@ <h6 class="dropdown-header">Select context collection</h6>
4949
<table class="table table-borderless">
5050
<tbody>
5151
<tr v-for="prop in currentCollection.Properties">
52-
<th>{{prop.Key}}</th>
53-
<td class="value" v-html="prop.Value"></td>
52+
<th style="white-space: nowrap;">{{prop.Key}}</th>
53+
<td style="width:100%;" class="value" v-html="prop.Value"></td>
5454
</tr>
5555
</tbody>
5656
</table>
5757
</div>
5858
</div>
5959
</div>
6060
</div>
61-
<div class="col-lg-7 col-xl-6 col-md-12">
61+
<div class="col-lg-12 col-xl-4">
6262
<div class="card" v-if="userFeedback != null">
6363
<div class="card-body">
6464
<h3>Error report from {{userOrEmail}}</h3>

‎src/Server/Coderr.Server.Web/ClientApp/components/analyze/incidents/status.vue.html‎

Lines changed: 34 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,40 @@
11
<template>
2-
<div class="StatusUpdateView">
3-
<div class="row">
4-
<div class="col">
5-
<h2>
6-
Send status update
7-
</h2>
2+
<div class="StatusUpdateView mt-4">
3+
<div class="container">
4+
<div class="row">
5+
<div class="col">
6+
<h2>
7+
Send status update
8+
</h2>
9+
</div>
10+
<hr />
811
</div>
9-
<hr />
10-
</div>
11-
<div class="row mb-2">
12-
<div class="col">
13-
<router-link :to="{ name: 'analyzeHome' }" class="btn btn-light">&lt;&lt; Back to analyze..</router-link>
12+
<div class="row mb-2">
13+
<div class="col">
14+
<router-link :to="{ name: 'analyzeHome' }" class="btn btn-light">&lt;&lt; Back to analyze..</router-link>
15+
</div>
1416
</div>
15-
</div>
16-
<div class="row">
17-
<div class="col">
18-
<div class="card">
19-
<div class="card-body">
20-
<div class="row">
21-
<div class="col-md-8">
22-
<h3>Message</h3>
23-
<form @submit.prevent="send">
24-
<div class="form-group">
25-
<input type="text" v-model="title" placeholder="Subject" required class="form-control" />
26-
</div>
27-
<div class="form-group">
28-
<textarea v-model="body" placeholder="Tell your users that the error (and which error) have been corrected and when the new application version will be available." required rows="10" class="form-control"></textarea>
29-
</div>
30-
<button class="btn btn-primary">Send</button>
31-
</form>
32-
</div>
33-
<div class="col-md-4">
34-
<h4>The following users will receive this message.</h4>
35-
<p><em>{{emailList}}</em></p>
17+
<div class="row">
18+
<div class="col">
19+
<div class="card">
20+
<div class="card-body">
21+
<div class="row">
22+
<div class="col-md-8">
23+
<h3>Message</h3>
24+
<form @submit.prevent="send">
25+
<div class="form-group">
26+
<input type="text" v-model="title" placeholder="Subject" required class="form-control" />
27+
</div>
28+
<div class="form-group">
29+
<textarea v-model="body" placeholder="Tell your users that the error (and which error) have been corrected and when the new application version will be available." required rows="10" class="form-control"></textarea>
30+
</div>
31+
<button class="btn btn-primary">Send</button>
32+
</form>
33+
</div>
34+
<div class="col-md-4">
35+
<h4>The following users will receive this message.</h4>
36+
<p><em>{{emailList}}</em></p>
37+
</div>
3638
</div>
3739
</div>
3840
</div>

‎src/Server/Coderr.Server.Web/ClientApp/components/discover/incidents/incident.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export default class IncidentComponent extends Vue {
9191
this.isClosed = true;
9292
if (result.requiresStatusUpdate) {
9393
this.$router.push({
94-
name: 'analyzeNotifyUsers',
94+
name: 'notifyUsers',
9595
params: { incidentId: this.incident.Id.toString() }
9696
});
9797
return;

‎src/Server/Coderr.Server.Web/ClientApp/components/discover/incidents/incident.vue.html‎

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,17 @@
55
<h3>{{incident.Description}} <small class="text-muted">[{{incident.FullName}}]</small></h3>
66
<div class="">
77
<a href="#" class="btn btn-light" v-on:click.prevent="$router.back()">&lt;&lt; Back ...</a>
8-
<div class="dropdown float-right">
9-
<button class="btn btn-outline-primary dropdown-toggle" type="button" id="dropdownMenuButton" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
10-
What do you want to do?
11-
</button>
12-
<div class="dropdown-menu" aria-labelledby="dropdownMenuButton">
13-
<a class="dropdown-item" href="#" v-if="incident.IncidentState == 0" v-on:click.prevent="assignToMe">Assign to me</a>
14-
<a class="dropdown-item" href="#" v-if="incident.IncidentState == 0" v-on:click.prevent="assignToSomeoneElse">Assign to ..</a>
15-
<a class="dropdown-item" href="#" v-if="!isClosed" v-on:click.prevent="close">Close</a>
16-
<a class="dropdown-item" href="#" v-if="!isClosed && !isIgnored" v-on:click.prevent="ignore">Ignore incident</a>
8+
<div class="float-right">
9+
<a class="btn btn-primary" href="#" v-if="incident.IncidentState == 0" v-on:click.prevent="assignToMe">Assign to me</a>
10+
<div class="dropdown" style="display: inline-block">
11+
<button class="btn btn-outline-primary dropdown-toggle" type="button" id="dropdownMenuButton" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
12+
Other actions
13+
</button>
14+
<div class="dropdown-menu" aria-labelledby="dropdownMenuButton">
15+
<a class="dropdown-item" href="#" v-if="incident.IncidentState == 0" v-on:click.prevent="assignToSomeoneElse">Assign to ..</a>
16+
<a class="dropdown-item" href="#" v-if="!isClosed" v-on:click.prevent="close">Close incident</a>
17+
<a class="dropdown-item" href="#" v-if="!isClosed && !isIgnored" v-on:click.prevent="ignore">Ignore incident</a>
18+
</div>
1719
</div>
1820
</div>
1921
</div>
@@ -76,7 +78,7 @@ <h3>Report history</h3>
7678
</div>
7779
<div class="row">
7880
<div class="col-lg-12">
79-
81+
8082

8183
</div>
8284
</div>

‎src/Server/Coderr.Server.Web/ClientApp/components/discover/incidents/search.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ export default class IncidentSearchComponent extends Vue {
266266
.then(x => {
267267
if (x.requiresStatusUpdate) {
268268
this.$router.push({
269-
name: 'analyzeNotifyUsers',
269+
name: 'notifyUsers',
270270
params: { incidentId: incidentId.toString() }
271271
});
272272
return;

‎src/Server/Coderr.Server.Web/ClientApp/components/home/support/support.vue.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div class="mt-4">
33
<div class="col-lg-12">
44
<div class="card" v-if="!sent">
5-
<div class="card-header">Get help</div>
5+
<div class="card-header">Get help or leave feedback</div>
66
<div class="card-body">
77
<textarea class="form-control" v-model="message" placeholder="Describe your problem" rows="10" id="SupportMessage" autofocus=""></textarea>
88
<button class="btn btn-primary" v-on:click.prevent="sendMessage">Send</button>

0 commit comments

Comments
 (0)