Skip to content

Conversation

@mdqst
Copy link
Contributor

@mdqst mdqst commented Sep 8, 2025

Description

fixed regex patterns in read_dependency_version and write_dependency_version to properly handle TOML syntax.

  • removed extra quotes around dependency_name
  • added re.escape
  • accounted for = "..." format
  • updated replacement to dependency_name = "{min_version},{max_version}"

now both functions correctly parse and write dependencies in TOML.

Tests

verified on sample TOML files that dependencies are now read and written correctly.

Checklist

A couple of things to include in your PR for completeness:

  • Added documentation to all relevant README.md files
  • Added a changelog entry

@mdqst mdqst requested a review from murrlincoln as a code owner September 8, 2025 08:24
@cb-heimdall
Copy link

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions bot added the python label Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants