-
Notifications
You must be signed in to change notification settings - Fork 578
Feat/dynamic takeover #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
phdargen
wants to merge
11
commits into
coinbase:main
Choose a base branch
from
phdargen:feat/dynamic-takeover
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
Jeddyvgf
approved these changes
Sep 30, 2025
|
Review Error for Jeddyvgf @ 2025-09-30 21:00:48 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
example
New example agent
typescript
wallet provider
New wallet provider
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation of #738 by @matthew1809 adding a Dynamic wallet provider
{chainId, networkId, chainType}->networkIdin agentkit standard formatEvmWalletProviderinstead ofViemWalletProviderOpen questions:
[DynamicWaasWalletClient] [ERROR]: Error in sign TypeError: Cannot read properties of undefined (reading 'secretShare');getExternalServerKeySharesreturns empty array. Tried bothbackUpToClientShareService: true/falsein wallet creationTests
Checklist
A couple of things to include in your PR for completeness: