Skip to content

Conversation

@phdargen
Copy link
Contributor

@phdargen phdargen commented Sep 30, 2025

Description

This PR is a continuation of #738 by @matthew1809 adding a Dynamic wallet provider

  • Rebased against main
  • Simplified network settings from using {chainId, networkId, chainType} -> networkId in agentkit standard format
  • Improved chatbot example to work for both evm and svm depending on env settings
  • Added logic for wallet retrieval from address
  • Bumped dynamic packages and updated code to use dynamic import() as packages published as ESM modules
  • Refactored to derive from EvmWalletProvider instead of ViemWalletProvider
  • Use Dynamic API for tx signing instead of viem client
  • Clean up console logs

Open questions:

  • It seems only one server wallet per evm/svm can be created. Is this due to free-tier API plan?
  • Tx signing still throws error: [DynamicWaasWalletClient] [ERROR]: Error in sign TypeError: Cannot read properties of undefined (reading 'secretShare'); getExternalServerKeyShares returns empty array. Tried both backUpToClientShareService: true/false in wallet creation
  • Does Dynamic support signTypedData? Otherwise actions like swap and x402 wont work

Tests

Checklist

A couple of things to include in your PR for completeness:

  • Added documentation to all relevant README.md files
  • Added a changelog entry

@cb-heimdall
Copy link

cb-heimdall commented Sep 30, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions bot added documentation Improvements or additions to documentation wallet provider New wallet provider example New example agent typescript labels Sep 30, 2025
@cb-heimdall
Copy link

Review Error for Jeddyvgf @ 2025-09-30 21:00:48 UTC
User must have write permissions to review

@phdargen phdargen marked this pull request as draft October 1, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation example New example agent typescript wallet provider New wallet provider

Development

Successfully merging this pull request may close these issues.

4 participants