Introduce Automatic payments

[lodewiges]

Checklist

• Merged database migrations into 1 database migration.
• Tested database migrations from origin/staging (git checkout staging ; git pull ; bundle exec rails db:reset ; git checkout BRANCH ; bundle exec rails db:migrate).

Summary

Shortly summarize the changes in this pull request. Does it concern changes in the UI, add some screenshots. Are there related issues solved? Please, mention them (with 'fixes #xyz', see https://github.com/blog/1506-closing-issues-via-pull-requests), so they can be resolved automatically when merging this pull request.

Other information

If there is some other relevant and important information for this pull request, mention it here. For example, related pull requests or newly introduced conventions, packages or other dependencies.

Summary by CodeRabbit

• New Features
  • Enhanced user payment section with additional payment transfer instructions.
  • Added iDEAL payment option for balance transfers when payment provider integration is enabled.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

A single view template is updated to display additional instruction text for bank transfers and add a conditional link to an iDEAL payment gateway. The changes include a new line instructing users to mention their name and organization reference, and a link that appears when the Mollie API is configured.

Changes

Cohort / File(s)	Summary
User saldo display updates app/views/users/show.html.erb	Adds instructional text "onder vermelding van je naam en 'Inleg Zatladder'." below existing IBAN messaging. Introduces conditional block to render iDEAL payment link (add_payments_path) when Mollie API key is configured.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

No complex logic or structural changes. Single template file with straightforward text addition and simple conditional rendering based on API configuration presence.

Poem

🐰 A link springs forth when Mollie's key awaits,
With words that guide the saldo's hopeful fate,
Through iDEAL the coins may softly flow,
In Zatladder's name, we reap what we did sow! ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title 'Introduce Automatic payments' is misleading; the actual change only adds an optional iDEAL payment link, not automatic payment functionality.	Revise the title to accurately reflect the change, such as 'Add optional iDEAL payment link in user saldo inleg section'.
Description check	⚠️ Warning	The pull request description is largely incomplete. It contains only the template structure without meaningful content in the Summary or Other information sections.	Provide a concrete summary of changes (UI modifications for iDEAL payment link), confirm database migration testing status, reference related issues with 'fixes #xyz' if applicable, and add screenshots if UI changes are significant.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR re-adds the Mollie payment link functionality to the user profile page, allowing users to add credit to their account via iDEAL payment when the Mollie API is configured.

• Adds additional instruction text for manual bank transfer payments
• Re-introduces the iDEAL payment link when Mollie API key is configured

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/views/users/show.html.erb (1)

126-132: Simplify string quoting and link_to usage in the new Mollie/iDEAL block

The new content works as-is, but can be made a bit clearer/cleaner:

• Line 126: using single quotes with an escaped ' hurts readability; switching to double quotes avoids the escape.
• Lines 128–131: the block-form link_to is overkill for static text and you have a trailing space in the string.

A more concise version:

<%= "Dat kan naar #{Rails.application.config.x.company_iban} t.n.v. #{Rails.application.config.x.company_name}" %>
<%= "onder vermelding van je naam en 'Inleg Zatladder'." %>

<% if Rails.application.config.x.mollie_api_key.present? %>
  <%= link_to 'Klik hier om je saldo over te maken via iDEAL', add_payments_path %>
<% end %>

This keeps behavior identical while improving readability and removing the stray trailing space.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 97d2fd7 and 33cafee.

📒 Files selected for processing (1)

• app/views/users/show.html.erb (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build

[codecov]

Codecov Report

❌ Patch coverage is 28.75817% with 109 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.49%. Comparing base (761e87c) to head (2f622ac).

Files with missing lines	Patch %	Lines
app/jobs/auto_charge_job.rb	0.00%	49 Missing ⚠️
app/controllers/payments_controller.rb	20.00%	48 Missing ⚠️
app/models/user.rb	53.33%	7 Missing ⚠️
app/policies/payment_policy.rb	50.00%	3 Missing ⚠️
app/models/payment.rb	90.47%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           staging    #1150      +/-   ##
===========================================
- Coverage    77.62%   72.49%   -5.14%     
===========================================
  Files           54       55       +1     
  Lines         1341     1487     +146     
===========================================
+ Hits          1041     1078      +37     
- Misses         300      409     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.