[RR] Do not add signoff when cherry picking commits #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During "rebase", the ciq commits are cherry picked one by one from the branch that contains the previous version of kernel. Since they are already signed off, there's no need to add another signoff. Moreover, this ends up appending signoffs every time a new rolling release update is done, polutting the commit message. Signed-off-by: Roxana Nicolescu <rnicolescu@ciq.com>
There was a problem hiding this comment.
Pull request overview
This PR removes the -s (signoff) flag from the git cherry-pick command during rolling release updates. The commits being cherry-picked in this context are existing CIQ commits from a previous kernel version that already contain signoffs. Without this change, every rolling release update would append additional signoffs to these commits, unnecessarily polluting the commit history.
Key Changes:
- Removed the
-sflag from the cherry-pick command in the rolling release update process
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During "rebase", the ciq commits are cherry picked one by one from the branch that contains the previous version of kernel. Since they are already signed off, there's no need to add another signoff. Moreover, this ends up appending signoffs every time a new rolling release update is done, polutting the commit message.