Skip to content

add drag handle #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
corexalys-admin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add drag handle #485

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c13da8
add drag handle
Jul 16, 2021
2374e42
Update src/components/graph/Graph.jsx
corexalys-admin Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/components/graph/Graph.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ import { merge, debounce, throwErr } from "../../utils";
* window.alert(`Graph is now zoomed at ${newZoom} from ${previousZoom}`);
* };
*
* const onDragChange = function(newZoom) {
* // newZoom is like {x: 1, y: 1, k: 1}
* window.alert(`Graph is now zoomed/dragged ending at ${newZoom}`);
* };
*
* <Graph
* id='graph-id' // id is mandatory, if no id is defined rd3g will throw an error
Expand All @@ -126,7 +130,8 @@ import { merge, debounce, throwErr } from "../../utils";
* onMouseOverLink={onMouseOverLink}
* onMouseOutLink={onMouseOutLink}
* onNodePositionChange={onNodePositionChange}
* onZoomChange={onZoomChange}/>
* onZoomChange={onZoomChange}
* onDragChange={onDragChange} />
*/
export default class Graph extends React.Component {
/**
Expand Down Expand Up @@ -300,6 +305,9 @@ export default class Graph extends React.Component {

if (!this.state.config.freezeAllDragEvents) {
zoomObject.on("zoom", this._zoomed);
if (this.onDragChange) {
zoomObject.on("end", this._zoomedEnd);
Copy link
Owner

@danielcaldas danielcaldas Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the use case for this?

Copy link
Author

@corexalys-admin corexalys-admin Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the use case is when we move the graph we need to handle the final position for save it in bdd and after reload we send an init position to the graph (i've not finish to code this part)

}
}

if (this.state.config.initialZoom !== null) {
Expand All @@ -311,6 +319,12 @@ export default class Graph extends React.Component {
selector.call(zoomObject).on("dblclick.zoom", null);
};

_zoomedEnd = () => {
const transform = d3Event.transform;

this.onDragChange && this.onDragChange(transform);
}

/**
* Handler for 'zoom' event within zoom config.
* @returns {Object} returns the transformed elements within the svg graph area.
Expand Down Expand Up @@ -545,6 +559,7 @@ export default class Graph extends React.Component {
this.isDraggingNode = false;
this.state = initializeGraphState(this.props, this.state);
this.debouncedOnZoomChange = this.props.onZoomChange ? debounce(this.props.onZoomChange, 100) : null;
this.onDragChange = this.props.onDragChange ? this.props.onDragChange : null;
}

/**
Expand Down