Skip to content

Fix Int64.toRadixStringUnsigned extra leading digits #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osa1 merged 3 commits into from
Dec 15, 2025
Merged

Fix Int64.toRadixStringUnsigned extra leading digits #926

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af5cc55
Fix Int64.toRadixStringUnsigned extra leading digits
osa1 Dec 12, 2025
a9ae12a
Fix formatting
osa1 Dec 12, 2025
6510786
Simplify
osa1 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkgs/fixnum/lib/src/int64_native.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,11 +362,11 @@ class Int64 implements IntX {
throw ArgumentError('toStringRadixUnsigned radix must be >= 2 and <= 36'
' (found $radix)');
}
if (value == 0) {
return '0';
}
// Split value into two 32-bit unsigned digits (v1, v0).
final v1 = value >>> 32;
if (v1 == 0) {
return value.toRadixString(radix);
}
var v0 = value.toUnsigned(32);
// Long division by a single digit: (q1, q0) = (v1, v0) ~/ radix, remainder r0.
final q1 = v1 ~/ radix;
Expand Down
19 changes: 18 additions & 1 deletion pkgs/fixnum/test/int64_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,7 +1140,24 @@ void main() {
});

test('toStringUnsigned', () {
List<Int64> values = [];
expect(Int64.MAX_VALUE.toStringUnsigned(), '9223372036854775807');
expect(Int32.MAX_VALUE.toInt64().toStringUnsigned(), '2147483647');
expect(Int64(2).toStringUnsigned(), '2');
expect(Int64(1).toStringUnsigned(), '1');
expect(Int64(0).toStringUnsigned(), '0');
expect(Int64(-1).toStringUnsigned(), '18446744073709551615');
expect(Int64(-2).toStringUnsigned(), '18446744073709551614');
expect(
Int32.MIN_VALUE.toInt64().toStringUnsigned(), '18446744071562067968');
expect(Int64.MIN_VALUE.toStringUnsigned(), '9223372036854775808');

List<Int64> values = [
Int64.MAX_VALUE,
Int64(1),
Int64(0),
Int64(-1),
Int64.MIN_VALUE,
];
for (int high = 0; high < 16; high++) {
for (int low = -2; low <= 2; low++) {
values.add((Int64(high) << (64 - 4)) + Int64(low));
Expand Down
Loading