-
Notifications
You must be signed in to change notification settings - Fork 13
refactor: extract shared select dropdown/list styles into central SCSS placeholders #5586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat-multi-select-native-select-styling-new
Are you sure you want to change the base?
refactor: extract shared select dropdown/list styles into central SCSS placeholders #5586
Conversation
|
…ceholders Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com>
Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Updated the wait condition for page navigation and added wait for selectors in multiple tests.
Proposed changes
Eliminates code duplication between CustomSelect components and native select
::pickerpseudo-element by extracting common styles into shared SCSS placeholders.Created:
packages/components/src/styles/internal/_select-dropdown-components.scss%select-dropdown-container- Dropdown positioning, shadow, sizing, background%select-list-container- Overflow behavior and max-height calculation%select-list-item- Base item styles (padding, background, border-radius)%select-list-item-interaction- Hover/active statesUpdated components to extend placeholders:
select.scss-::picker(select)andoptionelementscustom-select-dropdown.scss- Dropdown containercustom-select-list.scss- List containercustom-select-list-item.scss- List itemsReduces ~50 lines of duplicated styles while ensuring consistency across both implementations.
resolves #3654
Types of changes
Further comments
Single source of truth for select dropdown/list styling. Future modifications only need to occur in one location.
❤️ Thank you!
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/copilot/sub-pr-4624