Fix macOS build compatibility #4
Conversation
| @@ -63,6 +63,15 @@ std::string Utils::RandomAccountID() | |||
| return r; | |||
| } | |||
|
|
|||
| void GetLocalTime(struct tm& timeinfo, time_t& rawtime) | |||
There was a problem hiding this comment.
I would prefer to use localtime_r and then #define for localtime_s (or make this function constexpr if possible)
| set(CMAKE_CXX_STANDARD 17) | ||
|
|
||
| if (NOT DEFINED GIMUSRV_FRONTEND) | ||
| set(GIMUSRV_FRONTEND "STANDALONE") |
There was a problem hiding this comment.
Please make a new CMake preset for your target platform (which uses the VCPKG_ROOT env variable) rather than allowing the build to work without a specific frontend preset.
|
Please address the reviews and merge the last changes on the repo, the code builds fine under Windows so I will merge it once the conflicts are resolved, thanks! |
|
I can do this but since I don't have a macOS, I wouldn't be able to test. I'm sure plenty of things will break though... It's never easy |
I'm running on macOS, I should be able to sort it out. I just have not found the time to do it yet 👍. Its not needed in anyway for Windows, I just thought of this so that I could build the server on my laptop. |
3 participants
@arves100