Skip to content

chore: update devcontainer comments #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JamBalaya56562 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Open

chore: update devcontainer comments #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# [Choice] Debian / Ubuntu version: debian-10, debian-9, ubuntu-20.04, ubuntu-18.04
# See https://github.com/microsoft/vscode-dev-containers/tree/master/containers/debian
# [Choice] Debian / Ubuntu version: debian-12, debian-11, ubuntu-24.04, ubuntu-22.04
# See https://github.com/devcontainers/images/tree/main/src/base-debian
# and https://github.com/devcontainers/images/tree/main/src/base-ubuntu
ARG VARIANT=debian-12
FROM mcr.microsoft.com/vscode/devcontainers/base:${VARIANT}

Expand Down Expand Up @@ -48,7 +49,7 @@ RUN /bin/bash /tmp/node.sh 20.x
COPY scripts/docker-client.sh /tmp/
RUN /bin/bash /tmp/docker-client.sh

#Add user to docker group
# Add user to docker group
RUN sudo groupadd docker && sudo usermod -aG docker $USERNAME && newgrp docker

# act
Expand Down
4 changes: 2 additions & 2 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// For format details, see https://aka.ms/vscode-remote/devcontainer.json or this file's README at:
// https://github.com/microsoft/vscode-dev-containers/tree/v0.117.1/containers/go
// For format details, see https://aka.ms/vscode-remote/devcontainer.json
// or this file's README at: https://github.com/devcontainers/images/tree/main/src/go
{
"name": "devcontainers-ci",
"dockerFile": "Dockerfile",
Expand Down