Linting

Author: domdfcoding

domdf_python_tools/terminal.py

@@ -80,7 +80,7 @@ def clear() -> None:
 	"""
 
 	if os.name == "nt":  # pragma: no cover (!Windows)
-		os.system("cls")
+		os.system("cls")  # nosec: B607,B605
 	else:  # pragma: no cover (!Linux)
 		print("\033c", end='')
 

tests/test_paths.py

@@ -21,8 +21,6 @@
 from domdf_python_tools import paths
 from domdf_python_tools.paths import PathPlus, clean_writer
 
-# TODO: delete, write, read and append might want deprecating in favour of pathlib
-
 
 def test_maybe_make():
 	with TemporaryDirectory() as tmpdir:

tests/test_typing.py

@@ -49,14 +49,15 @@ def test_check_membership_true(obj, type_):
 				("abc", List[int]),
 				(1234, Sequence[bytes]),
 				(12.34, Set[str]),
-				(1234, Tuple[str, float, bytes]),  # todo: Position
-				(12.34, Tuple[int, bytes, str]),  # todo: Position
-				("abc", Tuple[int, float, bytes]),  # todo: Position
-				(1234, Dict[bytes, float]),  # todo: Position
-				(12.34, Dict[int, str]),  # todo: Position
+				(1234, Tuple[str, float, bytes]),
+				(12.34, Tuple[int, bytes, str]),
+				("abc", Tuple[int, float, bytes]),
+				(1234, Dict[bytes, float]),
+				(12.34, Dict[int, str]),
 				]
 		)
 def test_check_membership_false(obj, type_):
+	# todo: Positions for Tuple and Dict
 	assert not check_membership(obj, type_)
 
 

tests/test_units.py

@@ -31,7 +31,7 @@ class TestMul:
 	@pytest.mark.parametrize("obj", units_zero2thousand)
 	def test_mul_errors(self, obj):
 		with pytest.raises(NotImplementedError, match="Multiplying a unit by another unit is not allowed."):
-			Unit(17) * obj
+			Unit(17) * obj  # pylint: disable=expression-not-assigned
 
 	@pytest.mark.parametrize("obj", zero2thousand)
 	def test_mul(self, obj: int):
@@ -41,7 +41,7 @@ def test_mul(self, obj: int):
 	@pytest.mark.parametrize("obj", units_zero2thousand)
 	def test_rmul_errors(self, obj):
 		with pytest.raises(NotImplementedError, match="Multiplying a unit by another unit is not allowed."):
-			obj * Unit(17)
+			obj * Unit(17)  # pylint: disable=expression-not-assigned
 
 	@pytest.mark.parametrize("obj", units_ints_zero2thousand)
 	def test_pow_errors(self, obj):