Simplify names where applicable

Author: IEvangelist

src/Services/Catalog/Catalog.API/IntegrationEvents/EventHandling/OrderStatusChangedToAwaitingValidationIntegrationEventHandler.cs

@@ -14,7 +14,7 @@ public OrderStatusChangedToAwaitingValidationIntegrationEventHandler(
     {
         _catalogContext = catalogContext;
         _catalogIntegrationEventService = catalogIntegrationEventService;
-        _logger = logger ?? throw new System.ArgumentNullException(nameof(logger));
+        _logger = logger ?? throw new ArgumentNullException(nameof(logger));
     }
 
     public async Task Handle(OrderStatusChangedToAwaitingValidationIntegrationEvent @event)

src/Services/Catalog/Catalog.API/IntegrationEvents/EventHandling/OrderStatusChangedToPaidIntegrationEventHandler.cs

@@ -11,7 +11,7 @@ public OrderStatusChangedToPaidIntegrationEventHandler(
         ILogger<OrderStatusChangedToPaidIntegrationEventHandler> logger)
     {
         _catalogContext = catalogContext;
-        _logger = logger ?? throw new System.ArgumentNullException(nameof(logger));
+        _logger = logger ?? throw new ArgumentNullException(nameof(logger));
     }
 
     public async Task Handle(OrderStatusChangedToPaidIntegrationEvent @event)

src/Services/Identity/Identity.API/SeedData.cs

@@ -92,7 +92,7 @@ await retryPolicy.ExecuteAsync(async () =>
         });
     }
 
-    private static AsyncPolicy CreateRetryPolicy(IConfiguration configuration, Microsoft.Extensions.Logging.ILogger logger)
+    private static AsyncPolicy CreateRetryPolicy(IConfiguration configuration, ILogger logger)
     {
         var retryMigrations = false;
         bool.TryParse(configuration["RetryMigrations"], out retryMigrations);

src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/GracePeriodConfirmedIntegrationEventHandler.cs

@@ -10,7 +10,7 @@ public GracePeriodConfirmedIntegrationEventHandler(
         ILogger<GracePeriodConfirmedIntegrationEventHandler> logger)
     {
         _mediator = mediator;
-        _logger = logger ?? throw new System.ArgumentNullException(nameof(logger));
+        _logger = logger ?? throw new ArgumentNullException(nameof(logger));
     }
 
     /// <summary>

src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderStockRejectedIntegrationEventHandler.cs

@@ -9,7 +9,7 @@ public OrderStockRejectedIntegrationEventHandler(
         ILogger<OrderStockRejectedIntegrationEventHandler> logger)
     {
         _mediator = mediator;
-        _logger = logger ?? throw new System.ArgumentNullException(nameof(logger));
+        _logger = logger ?? throw new ArgumentNullException(nameof(logger));
     }
 
     public async Task Handle(OrderStockRejectedIntegrationEvent @event)

src/Services/Ordering/Ordering.Domain/GlobalUsings.cs

@@ -1,5 +1,5 @@
 global using System.Reflection;
-global using global::Microsoft.eShopOnContainers.Services.Ordering.Domain.Exceptions;
+global using Microsoft.eShopOnContainers.Services.Ordering.Domain.Exceptions;
 global using MediatR;
 global using Microsoft.eShopOnContainers.Services.Ordering.Domain.AggregatesModel.BuyerAggregate;
 global using Microsoft.eShopOnContainers.Services.Ordering.Domain.AggregatesModel.OrderAggregate;

src/Services/Ordering/Ordering.FunctionalTests/GlobalUsings.cs

@@ -1,8 +1,6 @@
-global using System;
-global using System.IO;
+global using System.IO;
 global using System.Net.Http;
 global using System.Security.Claims;
-global using System.Threading.Tasks;
 global using Microsoft.AspNetCore.Builder;
 global using Microsoft.AspNetCore.Hosting;
 global using Microsoft.AspNetCore.Http;

src/Services/Ordering/Ordering.UnitTests/Application/NewOrderCommandHandlerTest.cs

@@ -29,7 +29,7 @@ public async Task Handle_return_false_if_order_is_not_persisted()
         { ["cardExpiration"] = DateTime.Now.AddYears(1) });
 
         _orderRepositoryMock.Setup(orderRepo => orderRepo.GetAsync(It.IsAny<int>()))
-            .Returns(Task.FromResult<Order>(FakeOrder()));
+            .Returns(Task.FromResult(FakeOrder()));
 
         _orderRepositoryMock.Setup(buyerRepo => buyerRepo.UnitOfWork.SaveChangesAsync(default))
             .Returns(Task.FromResult(1));
@@ -39,7 +39,7 @@ public async Task Handle_return_false_if_order_is_not_persisted()
         var LoggerMock = new Mock<ILogger<CreateOrderCommandHandler>>();
         //Act
         var handler = new CreateOrderCommandHandler(_mediator.Object, _orderingIntegrationEventService.Object, _orderRepositoryMock.Object, _identityServiceMock.Object, LoggerMock.Object);
-        var cltToken = new System.Threading.CancellationToken();
+        var cltToken = new CancellationToken();
         var result = await handler.Handle(fakeOrderCmd, cltToken);
 
         //Assert

src/Services/Ordering/Ordering.UnitTests/GlobalUsings.cs

@@ -1,9 +1,4 @@
-global using System;
-global using System.Collections.Generic;
-global using System.Linq;
-global using System.Threading;
-global using System.Threading.Tasks;
-global using MediatR;
+global using MediatR;
 global using Microsoft.AspNetCore.Mvc;
 global using Microsoft.eShopOnContainers.Services.Ordering.API.Application.Commands;
 global using Microsoft.eShopOnContainers.Services.Ordering.API.Application.Models;

src/Services/Payment/Payment.API/IntegrationEvents/EventHandling/OrderStatusChangedToStockConfirmedIntegrationEventHandler.cs

@@ -14,7 +14,7 @@ public OrderStatusChangedToStockConfirmedIntegrationEventHandler(
     {
         _eventBus = eventBus;
         _settings = settings.Value;
-        _logger = logger ?? throw new System.ArgumentNullException(nameof(logger));
+        _logger = logger ?? throw new ArgumentNullException(nameof(logger));
 
         _logger.LogTrace("PaymentSettings: {@PaymentSettings}", _settings);
     }