Skip to content

Gather assembly references #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timcassell merged 13 commits into from
Dec 11, 2025
Merged

Gather assembly references #2508

timcassell merged 13 commits into from
Dec 11, 2025

Conversation

@timcassell
Copy link
Collaborator

@timcassell timcassell commented Jan 23, 2024 •
edited
Loading

Fixes #1197
Fixes #2344
Fixes #2371
Also fixes legacy packages.config issues with CsProjClassicNetToolchain (no open issue, but was mentioned in #2405 (comment)).
And this is a pre-requisite to adding support for extern alias (#2289).

@timcassell

This comment was marked as off-topic.

Sign in to view
@timcassell timcassell marked this pull request as ready for review January 23, 2024 13:16
@timcassell
Copy link
Collaborator Author

timcassell commented Feb 4, 2024

@AndreyAkinshin Can we get this in v0.14.0 also? Then I can make a follow-up PR changing the default .Net Framework toolchain to CsProjClassicNetToolchain instead of RoslynToolchain (this fixes the issue we ran into when we tried to do that in v.0.13.7).

@timcassell timcassell added this to the v0.14.0 milestone Feb 4, 2024
@timcassell timcassell mentioned this pull request Feb 4, 2024
Closed
@AndreyAkinshin
Copy link
Member

AndreyAkinshin commented Feb 12, 2024

@timcassell yes, we can, sorry for such a delay. I will check it out as soon as I have some time for that (I want to carefully review the changes, not just blindly merge it).

@timcassell timcassell force-pushed the references branch 2 times, most recently from d7dd87d to a52c605 Compare April 3, 2024 07:38
@timcassell timcassell mentioned this pull request Apr 5, 2024
Closed
@Tampa
Copy link

Tampa commented Apr 11, 2024

@AndreyAkinshin It's been two months since. What's the status on this?

@timcassell timcassell modified the milestones: v0.14.0, v0.15.x Aug 6, 2024
@timcassell timcassell mentioned this pull request Oct 29, 2024
Closed
@timcassell timcassell mentioned this pull request Nov 27, 2024
Open
@timcassell

This comment was marked as outdated.

Sign in to view
@timcassell
Copy link
Collaborator Author

timcassell commented Jan 2, 2025

I reverted my last commit because I forgot about the WithNuget feature. The feature makes it difficult to build the source project directly without generating our own csproj to reference it. Perhaps now that MsBuildArguments are stable we can remove the nuget feature and point users towards MSBuild properties. @adamsitnik @AndreyAkinshin Thoughts?

@timcassell timcassell mentioned this pull request Jun 17, 2025
Open
@timcassell timcassell mentioned this pull request Jul 21, 2025
Merged
@timcassell timcassell modified the milestones: v0.15.x, v0.16.0 Dec 3, 2025
@timcassell
Copy link
Collaborator Author

timcassell commented Dec 10, 2025

@filzrev Failure looks like it's due to #2875. It succeeds on my local. Do you know how to fix it?

D:\a\BenchmarkDotNet\BenchmarkDotNet.dotnet\sdk\10.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1005: Assets file 'D:\a\BenchmarkDotNet\BenchmarkDotNet\tests\BenchmarkDotNet.IntegrationTests\bin\Release\net8.0\BenchmarkDotNet.IntegrationTests-101\obj\BenchmarkDotNet.IntegrationTests\project.assets.json' doesn't have a target for 'net10.0'. Ensure that restore has run and that you have included 'net10.0' in the TargetFrameworks for your project. [D:\a\BenchmarkDotNet\BenchmarkDotNet\tests\BenchmarkDotNet.IntegrationTests\BenchmarkDotNet.IntegrationTests.csproj::TargetFramework=net10.0]

@filzrev
Copy link
Contributor

filzrev commented Dec 11, 2025 •
edited
Loading

It seems Environment.Version/RuntimeInformation.FrameworkDescription returns actual runtime version (.NET 10). when .NET runtime version is roll forwarded.

It might need to resolve original tfm by using AppContext.TargetFrameworkName.

@timcassell
Copy link
Collaborator Author

timcassell commented Dec 11, 2025

It seems Environment.Version/RuntimeInformation.FrameworkDescription returns actual runtime version (.NET 10). when .NET runtime version is roll forwarded.

It might need to resolve original tfm by using AppContext.TargetFrameworkName.

I just pushed a fix using TargetFrameworkAttribute similar to ClrRuntime.GetTargetOrCurrentVersion. Is AppContext.TargetFrameworkName better?

filzrev
filzrev reviewed Dec 11, 2025
View reviewed changes
@filzrev
Copy link
Contributor

filzrev commented Dec 11, 2025

I just pushed a fix using TargetFrameworkAttribute similar to ClrRuntime.GetTargetOrCurrentVersion. Is AppContext.TargetFrameworkName better?

It seems using TargetFrameworkAttribute internally.
https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/System/AppContext.cs,a32225958db6c714

@timcassell
Added TODO comment.
61eec2e
@timcassell
Add platform to fallback tfm.
343113c
@timcassell
Fix compile errors.
426700c
@timcassell
Merge branch 'master' into references
1cfb377 
# Conflicts:
#	src/BenchmarkDotNet/Environments/Runtimes/CoreRuntime.cs
#	src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliCommand.cs
@timcassell
Remove unused method.
c55ac8f
@timcassell timcassell merged commit bd5ec34 into master Dec 11, 2025
16 checks passed
@timcassell timcassell deleted the references branch December 11, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreyAkinshin AndreyAkinshin Awaiting requested review from AndreyAkinshin

1 more reviewer

@filzrev filzrev filzrev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area:Toolchains breaking change

Projects

None yet

Milestone

v0.16.0

5 participants

@timcassell @AndreyAkinshin @Tampa @filzrev