Collection of small llvm fixes #1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While gcc puts strings in .strtab and .shstrtab sections, llvm toolchain just uses .strtab. Adapt kpatch to handle both styles. Signed-off-by: Pete Swain <swine@google.com> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com> [small changes]
Signed-off-by: Pete Swain <swine@google.com> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com> [subject line]
Clang FDO adds a new, ignorable ELF section, .llvm.call-graph-profile Generalize to ignore all .llvm.* Signed-off-by: Pete Swain <swine@google.com> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com> [subject line]
Contributor
|
Thanx Joe!
I'll continue rebasing onto this, and @t-mon's gcc/arm64 changes
…On Tue, Sep 27, 2022, 1:11 PM Joe Lawrence ***@***.***> wrote:
These are spun out of @swine <https://github.com/swine>'s patchset #1302
<#1302> in the interest of
upstreaming sooner than the arm64 changes. This set pulls out the non-arm64
specific llvm fixes. I made minor changes along the way to align a little
closer to the project commit/code conventions. Internal x86 clang
integration tests passed.
------------------------------
You can view, comment on, or merge this pull request online at:
#1305
Commit Summary
- 5f6c596
<5f6c596>
kpatch-build: for clang, use .strtab if no .shstrtab
- 3704057
<3704057>
create-diff-object: ignore clang's .llvm_addrsig sections
- 85781b7
<85781b7>
create-diff-object: ignore .llvm.* sections
File Changes
(2 files <https://github.com/dynup/kpatch/pull/1305/files>)
- *M* kpatch-build/create-diff-object.c
<https://github.com/dynup/kpatch/pull/1305/files#diff-b11891a551552359c664b4475a7ed9f84b1d569d4c649a775c9ba23e53f4bbc8>
(4)
- *M* kpatch-build/kpatch-elf.c
<https://github.com/dynup/kpatch/pull/1305/files#diff-34ac08ea5c6226bf0b96263ebad6540b23756a585be92f11d0354372cac21bce>
(33)
Patch Links:
- https://github.com/dynup/kpatch/pull/1305.patch
- https://github.com/dynup/kpatch/pull/1305.diff
—
Reply to this email directly, view it on GitHub
<#1305>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH4XE2ANU5QLYE7EJDM4ALWANIGVANCNFSM6AAAAAAQXD4WZQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
yhcote
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are spun out of @swine's patchset #1302 in the interest of upstreaming sooner than the arm64 changes. This set pulls out the non-arm64 specific llvm fixes. I made minor changes along the way to align a little closer to the project commit/code conventions. Internal x86 clang integration tests passed.