-
Notifications
You must be signed in to change notification settings - Fork 11
fix: Migration script should also work for repos configured as "forks" #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the migration script to handle enterprise repositories configured as "forks" that don't have an "origin" remote. Previously, the script assumed all repos had an "origin" remote, which caused failures for fork repos configured with "edx" and "openedx" remotes instead.
- Adds conditional logic to detect whether a repo uses "origin" or fork-based remote configuration
- For fork repos, updates the main/master branch tracking remote from "openedx" to "edx"
- Changes debug settings to enable command tracing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6c2be9a to
3a4ad97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d17005b to
14aa29b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Previously, I had assumed all repos had an "origin" remote. This is a fatal assumption because several enterprise repos had been included in FORKED_REPOS on newer devstacks so they were configured without an "origin" remote. This fixes the migration script to handle the fork repo case---instead of re-writing the "origin" remote, re-point the main branch to track the "edx" remote instead of the "openedx" remote. ENT-11240 (epic: ENT-11239)
14aa29b to
ecd16b9
Compare
Previously, I had assumed all repos had an "origin" remote. This is a fatal assumption because several enterprise repos had been included in FORKED_REPOS on newer devstacks so they were configured without an "origin" remote. This fixes the migration script to handle the fork repo case---instead of re-writing the "origin" remote, re-point the main branch to track the "edx" remote instead of the "openedx" remote.
ENT-11240 (epic: ENT-11239)
Testing
From devstack:
That resulted in all 4 enterprise IDA checkouts to have their main/master branches re-target the "edx" remote. Re-running the command is idempotent: