Skip to content

Don't use index() to populate rerank score array #139240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kderusso wants to merge 4 commits into
base: main
Choose a base branch
from
+13 −3
Draft

Don't use index() to populate rerank score array #139240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a901d5f
Don't use index() to populate rerank score array
kderusso Dec 8, 2025
638a8e1
[CI] Auto commit changes from spotless
Dec 9, 2025
1f71a2f
Update docs/changelog/139240.yaml
kderusso Dec 9, 2025
83a9ff6
Merge branch 'main' into kderusso/reranker-oob-fix
kderusso Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/139240.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 139240
summary: Don't use index() to populate rerank score array
area: Relevance
type: bug
issues: []
11 changes: 8 additions & 3 deletions ...k/inference/rank/textsimilarity/TextSimilarityRankFeaturePhaseRankCoordinatorContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Comparator;
import java.util.List;
import java.util.Map;

Expand Down Expand Up @@ -193,9 +194,13 @@ protected InferenceAction.Request generateRequest(List<String> docFeatures) {
}

float[] extractScoresFromRankedDocs(List<RankedDocsResults.RankedDoc> rankedDocs) {
float[] scores = new float[rankedDocs.size()];
for (RankedDocsResults.RankedDoc rankedDoc : rankedDocs) {
scores[rankedDoc.index()] = rankedDoc.relevanceScore();
List<RankedDocsResults.RankedDoc> sortedRankedDocs = rankedDocs.stream()
.sorted(Comparator.comparingInt(RankedDocsResults.RankedDoc::index))
.toList();

float[] scores = new float[sortedRankedDocs.size()];
for (int i = 0; i < sortedRankedDocs.size(); i++) {
scores[i] = sortedRankedDocs.get(i).relevanceScore();
}
return scores;
}
Expand Down