Update hal_conf_extra.h to prevent "redefinition of symbol" warning #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent "redefinition of symbol" warning When using DaisyDuino w/ PlatformIO, the [guidance on the forum](https://forum.electro-smith.com/t/daisy-seed-arduino-development-in-vscode/3639/2) instructs us to add the build flag `-D HAL_SDRAM_MODULE_ENABLED`. Without this, the program will not link due to an `undefined reference to 'HAL_SDRAM_Init'` error. However, by manually defining the symbol, when we compile we see many "warning symbol redefined" errors. This `ifndef` guard quiets those warnings. It would probably be better to resolve the issue that requires us to manually define `HAL_SDRAM_MODULE_ENABLED` - what is `HAL_SDRAM_Init` and why is it missing? Unfortunately, this is deeper into the daisy source code that I'm comfortable going.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using DaisyDuino w/ PlatformIO, the guidance on the forum instructs us to add the build flag
-D HAL_SDRAM_MODULE_ENABLED. Without this, the program will not link due to anundefined reference to 'HAL_SDRAM_Init'error.However, by manually defining the symbol, when we compile we see many "warning symbol redefined" errors. This
ifndefguard quiets those warnings.It would probably be better to resolve the issue that requires us to manually define
HAL_SDRAM_MODULE_ENABLED- what isHAL_SDRAM_Initand why is it missing? Unfortunately, this is deeper into the daisy source code that I'm comfortable going.