Skip to content

Add missing volatile to status flags to prevent "infinite" loop after optimization #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheSlowGrowth wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing volatile to status flags to prevent "infinite" loop after optimization #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Bug Fixes

- SDMMC: fix an issue where status flags were optimized out, resulting in very long while loops

## v8.0.0

### Features
Expand Down
4 changes: 2 additions & 2 deletions src/util/sd_diskio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@
/* Disk status */
static volatile DSTATUS Stat = STA_NOINIT;
//static volatile UINT WriteStatus = 0, ReadStatus = 0;
static uint32_t WriteStatus = 0;
static uint32_t ReadStatus = 0;
static volatile uint32_t WriteStatus = 0;
static volatile uint32_t ReadStatus = 0;
/* Private function prototypes -----------------------------------------------*/
static DSTATUS SD_CheckStatus(BYTE lun);
DSTATUS SD_initialize(BYTE);
Expand Down
Loading