Test logging interface #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enigbe
force-pushed
the
2025-02-test-logging-interface
branch
2 times, most recently
from
da2edcc to
d85c5c5
Compare
enigbe
force-pushed
the
2025-02-test-logging-interface
branch
3 times, most recently
from
30bee82 to
4e59771
Compare
Starting with v1.2, the `idna_adapter` crate switched to use `icu4x`, which requires a rust version of 1.81, conflicting with our MSRV. Here, we hence pin `idna_adapter` to v1.1 in our MSRV CI.
Previously, we named internal fields/APIs `lspsX_service` as us being the client was implied. Since we're about to also add service-side functionalities, such naming would start to get confusing. We hence rename them to follow a `lspsX_client` scheme, and will add the service-side APIs using the `service` terminology.
.. and while we're at it we move the VSS child key indexes to constants.
.. we might eventually want to drop them anyways, but for now we rename them to make them easily discernable from their counterparts in `builder.rs`.
.. for consistency, as we're about to add `LSPS2ServiceConfig` there, too.
We add the capability to configure LSPS2 service mode in `Builder` and `LiquiditySourceBuilder`.
.. and forward it to our `LiquditySource`.
.. to align with other event handling variants: First log, then act, then emit event if everything went okay.
.. so far we just silently fail if something goes wrong, eventually we'll need to implement retrying channel opens to honor buy requests that didn't succeed on the first attempt.
…ervice-support Add bLIP-52 / LSPS2 service-side support
enigbe
force-pushed
the
2025-02-test-logging-interface
branch
from
4e59771 to
7e27939
Compare
General improvements: - Add TestConfig wrapper around Config to allow per-test log field overrides while preserving the general test setup. - Test facade logger. - Add logging module and validate log entries. - Improve UniFFI logging adding UniFFI flag for relevant log objects. - Remove facade level, because the concrete `Log` impl controls max log level.
enigbe
force-pushed
the
2025-02-test-logging-interface
branch
from
7e27939 to
56d5dc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This is another follow-up PR to lightningdevkit#407 where we test the
logfacade and custom logging interfaces.It follows an earlier conversation to address testing without explicitly configuring the logger in all test cases.