Skip to content

feat: Update next example and add backup to federation #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MrImmortal09 wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: Update next example and add backup to federation #222

MrImmortal09 wants to merge 16 commits into from

Conversation

@MrImmortal09
Copy link
Member

@MrImmortal09 MrImmortal09 commented Nov 12, 2025 •
edited
Loading

Changes done in this PR:

  • Add backupToFederation method in RecoveryService
  • Update Next Example
  • Update Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d21e0ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MrImmortal09 MrImmortal09 marked this pull request as ready for review November 12, 2025 17:31
alexlwn123
alexlwn123 requested changes Nov 19, 2025
View reviewed changes
docs/core/FedimintWallet/RecoveryService/backupToFederation.md Outdated
Comment on lines 27 to 31
await wallet.recovery.backupToFederation({
// [!code focus]
timestamp: Date.now(), // [!code focus]
note: 'My backup', // [!code focus]
}) // [!code focus]
Copy link
Member

@alexlwn123 alexlwn123 Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the newline is messing up the code focus

Image

docs/core/FedimintWallet/RecoveryService/subscribeToRecoveryProgress.md Outdated
Comment on lines 17 to 29
const unsubscribe = wallet.recovery.subscribeToRecoveryProgress(
// [!code focus]
(progress) => {
// [!code focus]
console.log('Module:', progress.module_id) // [!code focus]
console.log('Progress:', progress.progress) // [!code focus]
}, // [!code focus]
(error) => {
// [!code focus]
// [!code focus]
console.error('Recovery error:', error) // [!code focus]
}, // [!code focus]
) // [!code focus]
Copy link
Member

@alexlwn123 alexlwn123 Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might be formatting rules breaking this, but double check that the code focuses are correct. They should be on the same line as the code.

Image

docs/core/FedimintWallet/RecoveryService/backupToFederation.md Outdated

### `recovery.backupToFederation(metadata?: JSONValue)`

Backup the wallet state to the federation with optional metadata.
Copy link
Member

@alexlwn123 alexlwn123 Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a sentance that explains to the user how this should be used.

something like: "You should call this function periodically to refresh the user's backups"

alexlwn123
alexlwn123 requested changes Nov 19, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2025 •
edited
Loading

Size Change: +29 B (0%)

Total Size: 7.64 MB

Filename Size Change
packages/core/dist/testing.js 2.8 kB +29 B (+1.05%)
ℹ️ View Unchanged
Filename Size
packages/core/dist/index.js 1.55 kB
packages/create-fedimint-app/dist/index.mjs 17 kB
packages/react/dist/index.js 1.31 kB
packages/transport-web/dist/index.js 287 B
packages/transport-web/dist/worker.js 712 B
packages/types/dist/index.js 528 B
packages/types/dist/jsonClientConfig.js 75 B
packages/types/dist/utils.js 64 B
packages/wasm-bundler/fedimint_client_wasm_bg.wasm 3.81 MB
packages/wasm-web/fedimint_client_wasm_bg.wasm 3.81 MB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexlwn123 alexlwn123 Awaiting requested review from alexlwn123

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MrImmortal09 @alexlwn123