Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ issues:
- linters:
- govet
text: "copylocks"
- linters:
- revive
text: package-comments
- linters:
- staticcheck
text: "Do not rely on the global seed"
Expand Down
2 changes: 2 additions & 0 deletions agent/agent_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// agent_test contains tests for helper functions in the agent binary,
// including validation of TaskExecID behavior.
package main

import (
Expand Down
2 changes: 2 additions & 0 deletions client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package client contains helpers for working with containers managed by
// firecracker-containerd, such as computing rootfs paths inside a microVM.
package client

import "github.com/firecracker-microvm/firecracker-containerd/internal/bundle"
Expand Down
2 changes: 2 additions & 0 deletions config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package config defines configuration structures and helpers used by
// firecracker-containerd, including loading and validating config files.
package config

import (
Expand Down
2 changes: 2 additions & 0 deletions eventbridge/eventbridge.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package eventbridge implements an event forwarding bridge that translates
// and relays containerd events to firecracker-containerd components.
package eventbridge

import (
Expand Down
3 changes: 3 additions & 0 deletions firecracker-control/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package client implements a Go client for interacting with the
// firecracker-control service, providing access to VM and lifecycle
// management APIs.
package client

import (
Expand Down
2 changes: 2 additions & 0 deletions firecracker-control/cmd/containerd/gomod_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// gomod_test keeps the firecracker-control containerd command and its
// dependencies visible to Go's module tooling so they are not pruned.
package main

import "github.com/containerd/containerd/cmd/ctr/app"
Expand Down
2 changes: 2 additions & 0 deletions firecracker-control/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package service defines common constants shared by the firecracker-control
// service implementation, such as plugin identifiers.
package service

const (
Expand Down
2 changes: 2 additions & 0 deletions internal/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package internal contains shared helpers and internal utilities used
// across firecracker-containerd components.
package internal

import (
Expand Down
2 changes: 2 additions & 0 deletions internal/debug/debug.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package debug provides helpers for configuring firecracker-containerd
// logging and managing debug log levels across components.
package debug

import (
Expand Down
2 changes: 2 additions & 0 deletions internal/event/exchange.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package event provides internal event exchange utilities, supporting
// publish/subscribe patterns for firecracker-containerd components.
package event

import (
Expand Down
2 changes: 2 additions & 0 deletions internal/integtest/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package integtest provides shared configuration and utilities for
// integration tests across firecracker-containerd.
package integtest

import (
Expand Down
2 changes: 2 additions & 0 deletions internal/shim/shim.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package shim provides helpers for working with the containerd shim,
// including construction of Firecracker control socket addresses.
package shim

import (
Expand Down
2 changes: 2 additions & 0 deletions internal/vm/agent.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package vm provides helpers for managing Firecracker VMs, including
// agent-related IO handling utilities.
package vm

import (
Expand Down
2 changes: 2 additions & 0 deletions runtime/cpuset/cpuset_builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package cpuset provides helpers for constructing and managing cpusets
// used by Firecracker VMs and container workloads.
package cpuset

import (
Expand Down
2 changes: 2 additions & 0 deletions runtime/firecrackeroci/annotation.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package firecrackeroci defines OCI annotations and related helpers used by
// the Firecracker runtime integration.
package firecrackeroci

import (
Expand Down
2 changes: 2 additions & 0 deletions runtime/vm/mount.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package vm contains Firecracker VM runtime helpers, including utilities
// for preparing and managing container filesystem mounts inside VMs.
package vm

import (
Expand Down
2 changes: 2 additions & 0 deletions snapshotter/app/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package app implements the application layer for the snapshotter,
// including service initialization and GRPC wiring.
package app

import (
Expand Down
2 changes: 2 additions & 0 deletions snapshotter/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package config defines configuration structures and helpers for the
// demux snapshotter, including loading configuration from TOML files.
package config

import (
Expand Down
2 changes: 2 additions & 0 deletions snapshotter/demux/cache/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package cache implements a cache of remote snapshotters used by the
// demux snapshotter for routing requests and service discovery.
package cache

import (
Expand Down
3 changes: 3 additions & 0 deletions snapshotter/demux/internal/failing_snapshotter.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package internal contains internal test and helper implementations for
// the demux snapshotter, including a snapshotter that intentionally fails
// for error-path validation.
package internal

import (
Expand Down
2 changes: 2 additions & 0 deletions snapshotter/demux/metrics/discovery/service_discovery.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package discovery provides metrics and helpers for discovering remote
// snapshotter services used by the demux snapshotter.
package discovery

import (
Expand Down
2 changes: 2 additions & 0 deletions snapshotter/demux/metrics/proxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package metrics exposes Prometheus metrics for the demux snapshotter's
// proxy operations, providing visibility into request handling and failures.
package metrics

import (
Expand Down
2 changes: 2 additions & 0 deletions snapshotter/demux/proxy/address/http_resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package address defines resolvers for locating proxy network addresses
// used by the demux snapshotter's HTTP services.
package address

import (
Expand Down
2 changes: 2 additions & 0 deletions snapshotter/demux/proxy/snapshotter.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package proxy implements the proxy snapshotter used by the demux
// snapshotter to route requests to remote snapshotter backends.
package proxy

import (
Expand Down
2 changes: 2 additions & 0 deletions snapshotter/demux/snapshotter.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package demux implements the demux snapshotter, which routes snapshotter
// operations to remote backends based on image configuration.
package demux

import (
Expand Down
2 changes: 2 additions & 0 deletions snapshotter/internal/http_address_resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// http-address-resolver runs a small HTTP service that resolves snapshotter
// namespaces to proxy addresses for the demux snapshotter.
package main

import (
Expand Down
2 changes: 2 additions & 0 deletions snapshotter/internal/integtest/stargz/fs/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@
license that can be found in the NOTICE.md file.
*/

// Package config defines labels used to configure the Stargz remote
// snapshotter behavior in integration tests.
package config

const (
Expand Down
2 changes: 2 additions & 0 deletions snapshotter/internal/integtest/stargz/fs/source/source.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
limitations under the License.
*/

// Package source builds source information for stargz-based remote
// snapshots in integration tests by annotating image descriptors.
package source

import (
Expand Down
2 changes: 2 additions & 0 deletions snapshotter/internal/mount/collection.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// Package mount provides helpers for working with collections of
// containerd mounts.
package mount

import "github.com/containerd/containerd/mount"
Expand Down
2 changes: 2 additions & 0 deletions volume/cmd/volume-init/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
// express or implied. See the License for the specific language governing
// permissions and limitations under the License.

// volume-init reads volume mapping configuration from stdin and copies
// the requested directories into the guest volume image.
package main

import (
Expand Down