Client transport config #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and also split out the http client code into a separate module
…text, ClientConfig, and ClientCallInterceptor similar to the Python SDK. Introduce a ClientTransportProvider and update the JSONRPC and gRPC transport implementations. Introduce a new Client and ClientFactory implementations.
… to make use of it, and remove the http-client and grpc dependencies from the client config module
…t to be able to make use of the appropriate client based on the transport and update the JSONRPC and gRPC tests to extend this
…otificationConfig
…roto#pushNotificationConfig
…gets cached once retrieved
…d some convenience methods to AbstractClient
…t other server implementations that also support JSONRPC can make use of these tests. These tests will be skipped when testing other transports
…text, ClientConfig, and ClientCallInterceptor similar to the Python SDK. Introduce a ClientTransportProvider and update the JSONRPC and gRPC transport implementations. Introduce a new Client and ClientFactory implementations.
3 tasks
fjuma
force-pushed
the
client_agnostic_transport
branch
from
c826f3a to
26ab76d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to make the transport configuration specific to a given transport implementation.
This one will ease developer experience by providing a builder for configuring a Client in a more stricter way compare to what exists today.
Also, this will help at getting rid of strong coupling with different transport implementations.
Two benefits: