Skip to content

Conversation

@jaydee029
Copy link
Member

Re raised the old, unmerged PR #160
closed it by mistake while re forking the repository.

For issues

…ogging

Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks - same as the other PRs please can we change the upload artefacts to only happen on failure, and add the same into the PR builds, both with a retention period of 7 days

Signed-off-by: dhruv <dhruvj797@gmail.com>
@jaydee029
Copy link
Member Author

Looks good thanks - same as the other PRs please can we change the upload artefacts to only happen on failure, and add the same into the PR builds, both with a retention period of 7 days

done

@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for building

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-simplatform-pr-161-7p6bb for details. If you are unable to do so, please contact a member of the Galasa team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants