-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(core): Capture initialize attributes on MCP servers #18531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… logic for initialize requests, and improving session data handling
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
JPeer264
approved these changes
Dec 17, 2025
Member
JPeer264
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dcramer
pushed a commit
to getsentry/sentry-mcp
that referenced
this pull request
Dec 18, 2025
I shipped [a fix](getsentry/sentry-javascript#18531) to capture client name on stateless servers for `initialize` spans and it was released today. [Sentry SDK changelog](https://github.com/getsentry/sentry-javascript/releases/tag/10.32.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we get this attributes from the initialization request and response into the
initializespan:mcp.client.name,mcp.client.version,mcp.client.title(from request)mcp.server.name,mcp.server.version,mcp.server.title(from response)mcp.protocol.version(from both request and response)Changes:
initializerequest and set them on the span after creation intransport.tsinitializeresponse incompleteSpanWithResultsand add them to the spanbuildClientAttributesFromInfoandbuildServerAttributesFromInfoto build attributes directly fromPartyInfoobjectsCloses #18532 (added automatically)