Statements: Implement Rule 15.1

Adds a query to find uses of goto in the program. This was
originally marked as compiler implemented, but even though it is
true that the compiler can check this case we can still provide a
query for it.

Author: lcartey

c/misra/src/rules/RULE-15-1/GotoStatementUsed.ql

@@ -0,0 +1,21 @@
+/**
+ * @id c/misra/goto-statement-used
+ * @name RULE-15-1: The goto statement should not be used
+ * @description The goto statement shall not be used.
+ * @kind problem
+ * @precision very-high
+ * @problem.severity error
+ * @tags external/misra/id/rule-15-1
+ *       correctness
+ *       security
+ *       external/misra/obligation/advisory
+ */
+
+import cpp
+import codingstandards.c.misra
+
+from Stmt s
+where
+  not isExcluded(s, Statements6Package::gotoStatementUsedQuery()) and
+  (s instanceof GotoStmt or s instanceof ComputedGotoStmt)
+select s, "Use of goto."

c/misra/test/rules/RULE-15-1/GotoStatementUsed.expected

@@ -0,0 +1 @@
+| test.c:4:3:4:14 | goto ... | Use of goto. |

c/misra/test/rules/RULE-15-1/GotoStatementUsed.qlref

@@ -0,0 +1 @@
+rules/RULE-15-1/GotoStatementUsed.ql

c/misra/test/rules/RULE-15-1/test.c

@@ -0,0 +1,9 @@
+void test_goto() {
+  int x = 1;
+
+  goto label1; // NON_COMPLIANT
+
+label1:
+
+  x = 2;
+}

cpp/common/src/codingstandards/cpp/exclusions/c/RuleMetadata.qll

@@ -51,6 +51,7 @@ import Statements2
 import Statements3
 import Statements4
 import Statements5
+import Statements6
 import Strings1
 import Strings2
 import Strings3
@@ -107,6 +108,7 @@ newtype TCQuery =
   TStatements3PackageQuery(Statements3Query q) or
   TStatements4PackageQuery(Statements4Query q) or
   TStatements5PackageQuery(Statements5Query q) or
+  TStatements6PackageQuery(Statements6Query q) or
   TStrings1PackageQuery(Strings1Query q) or
   TStrings2PackageQuery(Strings2Query q) or
   TStrings3PackageQuery(Strings3Query q) or
@@ -163,6 +165,7 @@ predicate isQueryMetadata(Query query, string queryId, string ruleId, string cat
   isStatements3QueryMetadata(query, queryId, ruleId, category) or
   isStatements4QueryMetadata(query, queryId, ruleId, category) or
   isStatements5QueryMetadata(query, queryId, ruleId, category) or
+  isStatements6QueryMetadata(query, queryId, ruleId, category) or
   isStrings1QueryMetadata(query, queryId, ruleId, category) or
   isStrings2QueryMetadata(query, queryId, ruleId, category) or
   isStrings3QueryMetadata(query, queryId, ruleId, category) or

cpp/common/src/codingstandards/cpp/exclusions/c/Statements6.qll

@@ -0,0 +1,26 @@
+//** THIS FILE IS AUTOGENERATED, DO NOT MODIFY DIRECTLY.  **/
+import cpp
+import RuleMetadata
+import codingstandards.cpp.exclusions.RuleMetadata
+
+newtype Statements6Query = TGotoStatementUsedQuery()
+
+predicate isStatements6QueryMetadata(Query query, string queryId, string ruleId, string category) {
+  query =
+    // `Query` instance for the `gotoStatementUsed` query
+    Statements6Package::gotoStatementUsedQuery() and
+  queryId =
+    // `@id` for the `gotoStatementUsed` query
+    "c/misra/goto-statement-used" and
+  ruleId = "RULE-15-1" and
+  category = "advisory"
+}
+
+module Statements6Package {
+  Query gotoStatementUsedQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `gotoStatementUsed` query
+      TQueryC(TStatements6PackageQuery(TGotoStatementUsedQuery()))
+  }
+}

rule_packages/c/Statements6.json

@@ -0,0 +1,24 @@
+{
+  "MISRA-C-2012": {
+    "RULE-15-1": {
+      "properties": {
+        "obligation": "advisory"
+      },
+      "queries": [
+        {
+          "description": "The goto statement shall not be used.",
+          "kind": "problem",
+          "name": "The goto statement should not be used",
+          "precision": "very-high",
+          "severity": "error",
+          "short_name": "GotoStatementUsed",
+          "tags": [
+            "correctness",
+            "security"
+          ]
+        }
+      ],
+      "title": "The goto statement should not be used"
+    }
+  }
+}

rules.csv

@@ -697,7 +697,7 @@ c,MISRA-C-2012,RULE-14-1,Yes,Required,,,A loop counter shall not have essentiall
 c,MISRA-C-2012,RULE-14-2,Yes,Required,,,A for loop shall be well-formed,M6-5-1...M6-5-6,Statements4,Medium,
 c,MISRA-C-2012,RULE-14-3,Yes,Required,,,Controlling expressions shall not be invariant,,Statements5,Medium,
 c,MISRA-C-2012,RULE-14-4,Yes,Required,,,The controlling expression of an if statement and the controlling expression of an iteration-statement shall have essentially Boolean type,A5-0-2,Statements4,Medium,
-c,MISRA-C-2012,RULE-15-1,No,Advisory,,,The goto statement should not be used,A6-6-1,,Import,
+c,MISRA-C-2012,RULE-15-1,Yes,Advisory,,,The goto statement should not be used,A6-6-1,Statements6,Import,
 c,MISRA-C-2012,RULE-15-2,Yes,Required,,,The goto statement shall jump to a label declared later in the same function,M6-6-2,Statements2,Import,
 c,MISRA-C-2012,RULE-15-3,Yes,Required,,,"Any label referenced by a goto statement shall be declared in the same block, or in any block enclosing the goto statement",M6-6-1,Statements2,Import,
 c,MISRA-C-2012,RULE-15-4,Yes,Advisory,,,There should be no more than one break or goto statement used to terminate any iteration statement,,Statements2,Medium,