excluded_unless bug fix

[chargraves85]

Fixes Or Enhances

The verbiage in the documentation for both excluded_unless and required_unless is very similar. One would expect the opposite behavior for each when using multiple values of the same field that is being validated against.

For example:

This fails in all 3 cases in sample code

package main

import (
	"fmt"
	"github.com/go-playground/validator/v10"
)


type TestStruct struct {
	Foo int
	Bar string `validate:"excluded_unless=Foo 1 Foo 2"`
}

func main() {

	validator := validator.New()

	testA := TestStruct{
		Foo: 1,
		Bar: "test",
	}
	testB := TestStruct{
		Foo: 2,
		Bar: "test",
	}
	testC := TestStruct{
		Foo: 3,
		Bar: "test",
	}

	err := validator.Struct(testA)
	if err != nil {
		fmt.Println(err.Error())
	}

	err = validator.Struct(testB)
	if err != nil {
		fmt.Println(err.Error())
	}

	err = validator.Struct(testC)
	if err != nil {
		fmt.Println(err.Error())
	}

}

However, the equivilant opposite of this only fails in TestC

type TestStruct struct {
	Foo int
	Bar string `validate:"required_unless=Foo 1 Foo 2"`
}

func main() {

	validator := validator.New()

	testA := TestStruct{
		Foo: 1,
	}
	testB := TestStruct{
		Foo: 2,
	}
	
	err := validator.Struct(testA)
	if err != nil {
		fmt.Println(err.Error())
	}

	err = validator.Struct(testB)
	if err != nil {
		fmt.Println(err.Error())
	}

}

resolves #1306

[coveralls]

coverage: 73.749%. remained the same
when pulling 2cb9f1d on chargraves85:issue-1306-excluded_unless-expectation-parity-with-required_unless
into 0c1335d on go-playground:master.

[khoirulamri]

any update for this issue?

[chargraves85]

any update for this issue?

Looks like we have a conflict. I can update the PR but had no momentum on it when I first posted.

[nodivbyzero]

Please resolve the conflicts, and I’ll proceed with the approval

[chargraves85]

@nodivbyzero thank you. We should be ready.

[nodivbyzero]

is this change related to the excluded_unless?

[chargraves85]

sorry, moving back to command line, IDEA driving me nuts with go fmt

[chargraves85]

formatting and history cleaned up