WIP: Prevent Gd::default_instance bypassing placeholder instances.
#1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1410 |
Yarwin
force-pushed
the
bugfix/forward-instance-creation-through-class-db
branch
3 times, most recently
from
1b732f9 to
3b0f1b7
Compare
---- - Forward object creation through ClassDB to handle placeholder instances logic. - Remove blanket implementation of `__godot_default` – requiring repeatedly implementing `__godot_default()` for all user classes.
Yarwin
force-pushed
the
bugfix/forward-instance-creation-through-class-db
branch
from
3b0f1b7 to
a4a9bf6
Compare
Contributor
Author
|
I'm temporarily closing this PR unless we resolve how we should treat creation of the placeholders from an extension side. Forwarding creation through ClassDB – as this PR does – does not change current behavior at all (and makes code much more complicated). See: #1404 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1404 (comment)
Forwards instance creation from godot-rust through Godot – making sure that Godot-specific logic (creating placeholders and whatnot) is being run & preserved.
I'm marking it as a breaking change – API is the same (at least the exposed one) but it is breaking change in behavior which must be properly announced.
WIP – I want to give it solid beating after merging #1399 (+ Godot before 4.4 is not properly covered I think).