-
Notifications
You must be signed in to change notification settings - Fork 22
Bump to Swift 6 and fix Swift Syntax issues #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
All tests passing. I know it's an enormous PR but it's mostly deletions (yay! 🎉) and it mostly modernizes things for Swift 6 and Swift Syntax. |
|
Wow, thanks for digging into this. And like you said, this is quite the big PR!
|
You might want to take a look at this: https://github.com/Matejkob/swift-macro-compatibility-check. I saw it used here https://github.com/pointfreeco/swift-dependencies/blob/main/.github/workflows/ci.yml#L81
I always go by the minimum version Apple accepts submissions for in the App Store, which right now is Xcode 26.0 = Swift 6.0. In Apple's eyes Swift 5.9 is "App Store obsolete", and so it's obsolete in my eyes too.
I think this might be a case of perfect getting in the way of good. To me, maintaining a fork of MacroTesting is more agonizing than not getting 100% coverage. But as the author it's of course ultimately up to you. |
I've also made CI runs simpler.