delete entries from the cache when the TTL expires #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
cleanup-after-ttl
branch
2 times, most recently
from
5877433 to
2ce249b
Compare
Contributor
Author
|
@grandcat Friendly ping. Could I get a review of this PR? |
This was referenced Jul 2, 2021
marten-seemann
force-pushed
the
cleanup-after-ttl
branch
from
2ce249b to
95aac4d
Compare
Owner
|
Could you rebase this PR on latest master, please? |
marten-seemann
force-pushed
the
cleanup-after-ttl
branch
from
95aac4d to
1137789
Compare
marten-seemann
force-pushed
the
cleanup-after-ttl
branch
from
1137789 to
5892aef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of saving the TTL value (an integer, measuring the time in seconds), we now save the expiry timestamp for every response we receive. A "cleanup" go routine then goes through our cache every 10s and removes entries that have expired.