Create a sequential dispatcher for each request and response #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I don't have a performance test harness for this backend. Perhaps @bastewart or @TimWSpence could give it a try? |
Member
Author
|
It's 0.23.13-3-ad7196e-20230124T051427Z-SNAPSHOT in Maven Central snapshots. |
Member
Author
|
Also, the diff is mostly whitespace. |
Thanks Ross! Just linked this to #171 which includes some initial benchmarks at least. I haven't included results from using a parallel dispatcher but can do if that's helpful. Parallel is noticeably slower (and possibly not correct unless I've missed something?) |
Member
Author
|
Parallel is definitely incorrect. See #172. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests the theory of #157 that a sequential dispatcher will help performance.
I thought request and response could share, but creating the request and response on a compute thread rather than the servlet thread results in null path infos being passed to the HTTP app in the tests. This creates the dispatcher for the bodies, where we already have effects.