-
Notifications
You must be signed in to change notification settings - Fork 4
Gallery view component #2014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Gallery view component #2014
Conversation
edlu77
commented
Dec 11, 2025
- Add stories for database app layout variant - Gallery view #1822
…into gallery-view-component
…into gallery-view-component
…into gallery-view-component
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=lint,test,compodoc --conf... |
❌ Failed | 2m 46s | View ↗ |
nx affected --target=build,build-webcomponent,b... |
✅ Succeeded | 4m 5s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-12-19 21:16:01 UTC
🚀 Preview Deploy Report✅ Successfully deployed preview here |
LibbyUX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this happen @edlu77 !
I could have been clearer in my issue when I submitted #1822 - I was envisioning this story being a full page layout, including a header and footer, rather than a portion of the page. No worries if this isn't possible. If it is, should I edit #1822 to mention this?
It could be nice to see this as a full page layout, potentially, so that the background color, padding, cards behave responsively as specified in the Figma Gallery View layout component, with the whole layout entirely squared away. For me, this is a helpful layout template to have, so I don't have to worry about styles, margin, padding, responsive, and colors everytime I am specifying a new datapase page in Figma. Would this be a helpful component for our devs? What do you think?
Preview
Figma
|
Okay sure, I can make it this way. Does the filtering in the sidebar need to work here as well? |
|
@edlu77 It could be a mock filter menu, just like we have here: https://cdn.humanatlas.io/ui/storybook/design-system/?path=/story/design-system-filter-menu--default No expectations of the buttons actually filtering data down in the story, as we don't have real data here. If it could showcase the whole page's responsive behavior, though, that would be fantastic. The responsiveness can almost be borrowed from the KG currently, but make sure to reference the gallery view breakpoints from the design system, as that is most current for this layout. The only other difference from the KG is that we'll now have the toggle show/hide menu button in the header, so the whole menu will collapse and folks can view more of page and it's better for mobile. |
