ASCT+B Reporter - Test Coverage Prefinal #2015
Open
+6,910
−277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls, organ-table-selector
…tions, playground, root, search
…ts-asctb-reporter
…ts-asctb-reporter
…t, service, control pane, navbar and bimodel service
…ts-asctb-reporter
|
View your CI Pipeline Execution ↗ for commit 7f40049
☁️ Nx Cloud last updated this comment at |
🚀 Preview Deploy Report✅ Successfully deployed preview here |
axdanbol
requested changes
Dec 16, 2025
Contributor
axdanbol
left a comment
axdanbol
left a comment
There was a problem hiding this comment.
Needs to use queries/events from https://testing-library.com/ instead of manipulating the fixture for all component tests
apps/asctb-reporter/src/app/components/compare/compare.component.spec.ts
Outdated
Show resolved
Hide resolved
apps/asctb-reporter/src/app/components/compare/compare.component.spec.ts
Outdated
Show resolved
Hide resolved
apps/asctb-reporter/src/app/components/compare/compare.component.spec.ts
Outdated
Show resolved
Hide resolved
apps/asctb-reporter/src/app/components/compare/compare.component.ts
Outdated
Show resolved
Hide resolved
apps/asctb-reporter/src/app/components/compare/compare.component.ts
Outdated
Show resolved
Hide resolved
| { provide: Router, useValue: mockServices.router }, | ||
| ], | ||
| }); | ||
| return result.fixture.componentInstance; |
Contributor
There was a problem hiding this comment.
Don't use fixture. https://testing-library.com/
| }); | ||
|
|
||
| it('should initialize and handle navigation', async () => { | ||
| const { fixture } = await setup(); |
Contributor
There was a problem hiding this comment.
Don't use fixture. https://testing-library.com/
|
|
||
| getData(title: string) { | ||
| const index = REGISTRY.map((e) => e.urlTitle).indexOf(title); | ||
| this.http.get(REGISTRY[index].path, { responseType: 'text' }).subscribe((data) => { |
…ts-asctb-reporter
…ts-asctb-reporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves the GitHub issue:
This PR improves test coverage for the ASCT+B Reporter app: