Humanatlas test coverage #2017
Draft
Humanatlas test coverage #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit bcbedcb
☁️ Nx Cloud last updated this comment at |
🚀 Preview Deploy Report✅ Successfully deployed preview here |
axdanbol
requested changes
Dec 16, 2025
Contributor
axdanbol
left a comment
axdanbol
left a comment
There was a problem hiding this comment.
Must use https://testing-library.com/ instead of fixture in all tests
axdanbol
requested changes
Dec 17, 2025
Contributor
There was a problem hiding this comment.
Please don't use container.querySelector from the render result - that is no better that using fixture. Use queries such as screen.findBy*, screen.getBy* from the testing library instead. Examples: https://testing-library.com/docs/angular-testing-library/examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.