This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Remove requirement to use harden-runner action #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all the time it was applied, no single repo cared enough to enable `block` policy for egress network traffic. All the action did is it produced churn where we were updating tags for the action to new versions. We *could* switch these actions to `block` but I'd rather remove the requirement if in all this time we haven't seen an actual need. Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
Contributor
Author
|
sdg: instructlab/sdg#677 |
courtneypacheco
approved these changes
Jun 19, 2025
ktdreyer
approved these changes
Jun 23, 2025
Contributor
ktdreyer
left a comment
ktdreyer
left a comment
There was a problem hiding this comment.
It's a cool technology, but we lack the collective team bandwidth to enforce it, and it's just noise at this point.
Contributor
Author
|
This was implemented in all repos already. Merging to reflect reality. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all the time it was applied, no single repo cared enough to enable
blockpolicy for egress network traffic. All the action did is itproduced churn where we were updating tags for the action to new
versions.
We could switch these actions to
blockbut I'd rather remove therequirement if in all this time we haven't seen an actual need.
Signed-off-by: Ihar Hrachyshka ihar.hrachyshka@gmail.com