correct error version #117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apconole
reviewed
Dec 12, 2024
Contributor
apconole
left a comment
apconole
left a comment
There was a problem hiding this comment.
I don't think this change is appropriate. We have the 1.1 branch which carries the version for 1.1. This branch is the current mainline, and that will become 1.2 whenever enough features have been accumulated.
apconole
reviewed
Jan 8, 2025
| @@ -1,4 +1,4 @@ | |||
| AC_INIT([lldpad], [1.2.99], [lldp-devel@open-lldp.org]) | |||
| AC_INIT([lldpad], [1.1.1], [lldp-devel@open-lldp.org]) | |||
Contributor
There was a problem hiding this comment.
Why do you think this should change?
This value will be a hint on bug reports. IE: if someone writes a bug and shows 1.2.90, then we know it is
against latest main branch. OTOH, 1.1.1 should be found on branch-1.1 and that will be a very specific version.
Contributor
|
Closing this. If you're looking for the 1.1 branch, see the branch-1.1 Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.