fix implicit import warning #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
utnapischtim
commented
Dec 2, 2025
utnapischtim
commented
- nicer work, but useless, because of following commit
- feat: improve import usage
* the warning was not working as intended. * since it is complicated programmatically to distinguish between 'import idutils' and 'from idutils import XY' to write a warning only on one of the both cases and it is not the packages business to decide how the package which is using it will import functions from modules, the whole warning has been removed and the user can decide how it will be imported * relying only on 'from idutils.module_a import func_xy' would mean that all all packages which are using this have to rewrite there code with not really any real benefit * all those points lead to the removal of the warning. btw this behavior is the same now as it was with the warning.
utnapischtim
force-pushed
the
fix-implicit-import-warning
branch
from
f429a37 to
010612b
Compare
zzacharo
approved these changes
Dec 3, 2025
tmorrell
requested changes
Dec 3, 2025
Contributor
tmorrell
left a comment
tmorrell
left a comment
There was a problem hiding this comment.
I don't think this works if you're importing the module from outside of the idutils directory. If I install the fork with pip and run from the idutils directory
import idutils
print(dir(idutils))
I get all the functions. But if I move to another directory on my machine and run the same code I just get
['__doc__', '__file__', '__loader__', '__name__', '__package__', '__path__', '__spec__']
I think there is an location implied in the . import
tmorrell
approved these changes
Dec 3, 2025
Contributor
tmorrell
left a comment
tmorrell
left a comment
There was a problem hiding this comment.
I got confused by a separate bug on editable installs.
Contributor
Author
|
NOTE: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.