Skip to content

Conversation

@rodiazet
Copy link
Member

@rodiazet rodiazet commented Dec 2, 2025

Depends on: #1390

Before:

(vvenv) rodia@MacBook-Pro-2 evmone % ./build/bin/evmone-precompiles-bench --benchmark_filter=ecrecover
Unable to determine clock rate from sysctl: hw.cpufrequency: No such file or directory
This does not affect benchmark measurements, only the metadata output.
***WARNING*** Failed to set thread affinity. Estimated CPU frequency may be incorrect.
2025-12-02T15:19:01+01:00
Running ./build/bin/evmone-precompiles-bench
Run on (12 X 24 MHz CPU s)
CPU Caches:
  L1 Data 64 KiB
  L1 Instruction 128 KiB
  L2 Unified 4096 KiB (x12)
Load Average: 3.56, 2.97, 2.78
----------------------------------------------------------------------------------------------------------
Benchmark                                                Time             CPU   Iterations UserCounters...
----------------------------------------------------------------------------------------------------------
precompile<PrecompileId::ecrecover, evmmax_cpp>     106896 ns       106887 ns         6520 gas_rate=28.067M/s gas_used=30k

After:

(vvenv) rodia@MacBook-Pro-2 evmone % ./build/bin/evmone-precompiles-bench --benchmark_filter=ecrecover
Unable to determine clock rate from sysctl: hw.cpufrequency: No such file or directory
This does not affect benchmark measurements, only the metadata output.
***WARNING*** Failed to set thread affinity. Estimated CPU frequency may be incorrect.
2025-12-02T15:34:58+01:00
Running ./build/bin/evmone-precompiles-bench
Run on (12 X 24 MHz CPU s)
CPU Caches:
  L1 Data 64 KiB
  L1 Instruction 128 KiB
  L2 Unified 4096 KiB (x12)
Load Average: 1.50, 2.15, 2.37
----------------------------------------------------------------------------------------------------------
Benchmark                                                Time             CPU   Iterations UserCounters...
----------------------------------------------------------------------------------------------------------
precompile<PrecompileId::ecrecover, evmmax_cpp>      82527 ns        82527 ns         8470 gas_rate=36.3516M/s gas_used=30k

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 95.31250% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.81%. Comparing base (1098f42) to head (bb733ea).

Files with missing lines Patch % Lines
lib/evmone_precompiles/ecc.hpp 95.08% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
+ Coverage   81.66%   81.81%   +0.14%     
==========================================
  Files         152      152              
  Lines       13563    13723     +160     
  Branches     3216     3228      +12     
==========================================
+ Hits        11076    11227     +151     
- Misses        343      348       +5     
- Partials     2144     2148       +4     
Flag Coverage Δ
eest-develop 91.22% <95.31%> (+0.09%) ⬆️
eest-develop-gmp 29.91% <95.31%> (+0.76%) ⬆️
eest-legacy 15.17% <0.00%> (-0.18%) ⬇️
eest-legacy-silkpre 25.29% <93.75%> (+0.79%) ⬆️
evmone-unittests 76.40% <95.31%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 94.40% <95.31%> (-0.01%) ⬇️
tooling 83.63% <ø> (ø)
tests 73.52% <ø> (ø)
Files with missing lines Coverage Δ
lib/evmone_precompiles/secp256k1.cpp 100.00% <100.00%> (ø)
lib/evmone_precompiles/ecc.hpp 94.86% <95.08%> (-0.49%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rodiazet rodiazet requested a review from chfast December 2, 2025 11:44
@rodiazet rodiazet added the has_dependencies PR depends on not merged yet PR label Dec 2, 2025
@chfast chfast force-pushed the ecrecover-opt branch 2 times, most recently from 6f9b167 to 4c2d708 Compare December 18, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has_dependencies PR depends on not merged yet PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants